<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body><div><div style="font-family: Calibri,sans-serif; font-size: 11pt;">I an new in community, and would request the Mentors to help me head start in bug fixing and contribute in VLC with introductory bugs or tutorial.</div></div><div dir="ltr"><hr><span style="font-family: Calibri,sans-serif; font-size: 11pt; font-weight: bold;">From: </span><span style="font-family: Calibri,sans-serif; font-size: 11pt;"><a href="mailto:vlc-devel-request@videolan.org">vlc-devel-request@videolan.org</a></span><br><span style="font-family: Calibri,sans-serif; font-size: 11pt; font-weight: bold;">Sent: </span><span style="font-family: Calibri,sans-serif; font-size: 11pt;">08-02-2015 16:30</span><br><span style="font-family: Calibri,sans-serif; font-size: 11pt; font-weight: bold;">To: </span><span style="font-family: Calibri,sans-serif; font-size: 11pt;"><a href="mailto:vlc-devel@videolan.org">vlc-devel@videolan.org</a></span><br><span style="font-family: Calibri,sans-serif; font-size: 11pt; font-weight: bold;">Subject: </span><span style="font-family: Calibri,sans-serif; font-size: 11pt;">vlc-devel Digest, Vol 93, Issue 9</span><br><br></div>Send vlc-devel mailing list submissions to<br> vlc-devel@videolan.org<br><br>To subscribe or unsubscribe via the World Wide Web, visit<br> https://mailman.videolan.org/listinfo/vlc-devel<br>or, via email, send a message with subject or body 'help' to<br> vlc-devel-request@videolan.org<br><br>You can reach the person managing the list at<br> vlc-devel-owner@videolan.org<br><br>When replying, please edit your Subject line so it is more specific<br>than "Re: Contents of vlc-devel digest..."<br><br><br>Today's Topics:<br><br> 1. [PATCH] subpicture: fix memory leaks (Hannes Domani)<br> 2. access: rar: fix memory leaks of unused naming scheme<br> (Hannes Domani)<br> 3. Re: [PATCH] Fix pan handling for changing volume/brightness<br> (Filipe Cabecinhas)<br> 4. [PATCH] avcodec: fix double free on failure to open audio<br> (Alex Converse)<br> 5. Re: [vlc-commits] demux: mpeg: add some more DTS header<br> checks (fix #13843) (Jean-Baptiste Kempf)<br> 6. Re: [PATCH] avcodec: fix double free on failure to open audio<br> (Jean-Baptiste Kempf)<br> 7. Re: [PATCH] avcodec: fix double free on failure to open audio<br> (Alex Converse)<br> 8. Re: [PATCH] avcodec: fix double free on failure to open audio<br> (Jean-Baptiste Kempf)<br><br><br>----------------------------------------------------------------------<br><br>Message: 1<br>Date: Sat, 7 Feb 2015 15:01:24 +0000 (UTC)<br>From: Hannes Domani <ssbssa@yahoo.de><br>To: vlc-devel <vlc-devel@videolan.org><br>Subject: [vlc-devel] [PATCH] subpicture: fix memory leaks<br>Message-ID:<br> <1421657069.1255367.1423321284476.JavaMail.yahoo@mail.yahoo.com><br>Content-Type: text/plain; charset="utf-8"<br><br>Hello<br><br>Again some of those palette leaks.<br><br><br>Regards<br>Domani Hannes<br>-------------- next part --------------<br>A non-text attachment was scrubbed...<br>Name: 0001-subpicture-fix-memory-leaks.patch<br>Type: application/octet-stream<br>Size: 816 bytes<br>Desc: not available<br>URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20150207/0b36a427/attachment-0001.obj><br><br>------------------------------<br><br>Message: 2<br>Date: Sat, 7 Feb 2015 15:11:20 +0000 (UTC)<br>From: Hannes Domani <ssbssa@yahoo.de><br>To: vlc-devel <vlc-devel@videolan.org><br>Subject: [vlc-devel] access: rar: fix memory leaks of unused naming<br> scheme<br>Message-ID:<br> <1409788443.1242872.1423321880061.JavaMail.yahoo@mail.yahoo.com><br>Content-Type: text/plain; charset="utf-8"<br><br>Hello<br><br>I was a bit surprised when I saw that both naming variants were checked.<br>Isn't it encoded in the header which variant is used?<br><br><br>Regards<br>Domani Hannes<br>-------------- next part --------------<br>A non-text attachment was scrubbed...<br>Name: 0001-access-rar-fix-memory-leaks-of-unused-naming-scheme.patch<br>Type: application/octet-stream<br>Size: 1701 bytes<br>Desc: not available<br>URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20150207/69c6dd95/attachment-0001.obj><br><br>------------------------------<br><br>Message: 3<br>Date: Sat, 7 Feb 2015 11:03:08 -0800<br>From: Filipe Cabecinhas <vlc@filcab.net><br>To: Mailing list for VLC media player developers<br> <vlc-devel@videolan.org><br>Subject: Re: [vlc-devel] [PATCH] Fix pan handling for changing<br> volume/brightness<br>Message-ID: <9FCAC07C-F688-448C-A902-E8FD34B4671F@filcab.net><br>Content-Type: text/plain; charset=utf-8<br><br>Hi Felix,<br><br>Sorry, I forgot about that list again (but I'm subscribed).<br>I'll start sending patches that way, if I'm doing iOS related stuff.<br><br>Thanks,<br><br> Filipe<br><br>> On Feb 7, 2015, at 01:38, Felix Paul K?hne <fkuehne@videolan.org> wrote:<br>> <br>> Hello Filipe,<br>> <br>>> On 07 Feb 2015, at 07:26, Filipe Cabecinhas <vlc@filcab.net> wrote:<br>>> <br>>> Commit 479cc4b3 ended up breaking our ability to pan and easily change<br>>> volume/brightness.<br>>> <br>>> This fixes it, and makes our panRecognized: event handler more efficient<br>>> by avoiding string comparisons.<br>> <br>> Merged, thanks a lot!<br>> <br>> To monitor our development activities on iOS and to directly send patches to the iOS team, you are welcome to join our iOS mailing-list :)<br>> <br>> Cheers,<br>> <br>> Felix<br>> _______________________________________________<br>> vlc-devel mailing list<br>> To unsubscribe or modify your subscription options:<br>> https://mailman.videolan.org/listinfo/vlc-devel<br><br><br><br>------------------------------<br><br>Message: 4<br>Date: Sat, 7 Feb 2015 12:30:32 -0800<br>From: Alex Converse <alex.converse@gmail.com><br>To: vlc-devel@videolan.org<br>Subject: [vlc-devel] [PATCH] avcodec: fix double free on failure to<br> open audio<br>Message-ID: <1423341032-2565-1-git-send-email-alex.converse@gmail.com><br><br>---<br> modules/codec/avcodec/audio.c | 1 -<br> 1 file changed, 1 deletion(-)<br><br>diff --git a/modules/codec/avcodec/audio.c b/modules/codec/avcodec/audio.c<br>index a37f1cf..514f76d 100644<br>--- a/modules/codec/avcodec/audio.c<br>+++ b/modules/codec/avcodec/audio.c<br>@@ -261,7 +261,6 @@ int InitAudioDec( decoder_t *p_dec, AVCodecContext *p_context,<br> /* ***** Open the codec ***** */<br> if( OpenAudioCodec( p_dec ) < 0 )<br> {<br>- av_free( p_context->extradata );<br> free( p_sys );<br> return VLC_EGENERIC;<br> }<br>-- <br>1.9.1<br><br><br><br>------------------------------<br><br>Message: 5<br>Date: Sun, 8 Feb 2015 09:03:00 +0100<br>From: Jean-Baptiste Kempf <jb@videolan.org><br>To: vlc-devel@videolan.org<br>Cc: vlc-commits@videolan.org<br>Subject: Re: [vlc-devel] [vlc-commits] demux: mpeg: add some more DTS<br> header checks (fix #13843)<br>Message-ID: <20150208080300.GA7201@videolan.org><br>Content-Type: text/plain; charset=us-ascii<br><br>On 07 Feb, Francois Cartegnie wrote :<br>> vlc | branch: master | Francois Cartegnie <fcvlcdev@free.fr> | Sat Feb 7 19:56:14 2015 +0100| [1f0c9de8b05929cd24cc23d0ec26678ce5ba2d8b] | committer: Francois Cartegnie<br>> <br>> demux: mpeg: add some more DTS header checks (fix #13843)<br><br>It also fixes #8803, #10477, 1 sample out of 2 of #8387.<br><br>With my kindest regards,<br><br>-- <br>Jean-Baptiste Kempf<br>http://www.jbkempf.com/ - +33 672 704 734<br>Sent from my Electronic Device<br><br><br>------------------------------<br><br>Message: 6<br>Date: Sun, 8 Feb 2015 09:18:36 +0100<br>From: Jean-Baptiste Kempf <jb@videolan.org><br>To: Mailing list for VLC media player developers<br> <vlc-devel@videolan.org><br>Subject: Re: [vlc-devel] [PATCH] avcodec: fix double free on failure<br> to open audio<br>Message-ID: <20150208081836.GA9023@videolan.org><br>Content-Type: text/plain; charset=us-ascii<br><br>On 07 Feb, Alex Converse wrote :<br>> ---<br>> modules/codec/avcodec/audio.c | 1 -<br>> 1 file changed, 1 deletion(-)<br>> <br>> diff --git a/modules/codec/avcodec/audio.c b/modules/codec/avcodec/audio.c<br>> index a37f1cf..514f76d 100644<br>> --- a/modules/codec/avcodec/audio.c<br>> +++ b/modules/codec/avcodec/audio.c<br>> @@ -261,7 +261,6 @@ int InitAudioDec( decoder_t *p_dec, AVCodecContext *p_context,<br>> /* ***** Open the codec ***** */<br>> if( OpenAudioCodec( p_dec ) < 0 )<br>> {<br>> - av_free( p_context->extradata );<br>> free( p_sys );<br>> return VLC_EGENERIC;<br>> }<br><br>I have a hard time seeing where the extradata is, in fact, freed.<br><br>And I guess we have the same issue with subtitle part.<br><br>With my kindest regards,<br><br>-- <br>Jean-Baptiste Kempf<br>http://www.jbkempf.com/ - +33 672 704 734<br>Sent from my Electronic Device<br><br><br>------------------------------<br><br>Message: 7<br>Date: Sun, 8 Feb 2015 00:42:20 -0800<br>From: Alex Converse <alex.converse@gmail.com><br>To: Mailing list for VLC media player developers<br> <vlc-devel@videolan.org><br>Subject: Re: [vlc-devel] [PATCH] avcodec: fix double free on failure<br> to open audio<br>Message-ID:<br> <CALXxgACz5UkCspbYmziV7pGxrGZiSutjt+tmH8bv2JQBqVn2Vg@mail.gmail.com><br>Content-Type: text/plain; charset="utf-8"<br><br>So it's freed in avcodec_free_context() its been freed there in all<br>versions of libav and ffmpeg that have that function. It's also freed in<br>the current version of VLC compat but not older versions.<br><br>See<br>http://git.videolan.org/?p=vlc.git;a=commitdiff;h=a9ac943471c67fb3416f21246e389decda12cc38<br>for a the relevant compat change.<br>On Feb 8, 2015 12:18 AM, "Jean-Baptiste Kempf" <jb@videolan.org> wrote:<br><br>> On 07 Feb, Alex Converse wrote :<br>> > ---<br>> > modules/codec/avcodec/audio.c | 1 -<br>> > 1 file changed, 1 deletion(-)<br>> ><br>> > diff --git a/modules/codec/avcodec/audio.c<br>> b/modules/codec/avcodec/audio.c<br>> > index a37f1cf..514f76d 100644<br>> > --- a/modules/codec/avcodec/audio.c<br>> > +++ b/modules/codec/avcodec/audio.c<br>> > @@ -261,7 +261,6 @@ int InitAudioDec( decoder_t *p_dec, AVCodecContext<br>> *p_context,<br>> > /* ***** Open the codec ***** */<br>> > if( OpenAudioCodec( p_dec ) < 0 )<br>> > {<br>> > - av_free( p_context->extradata );<br>> > free( p_sys );<br>> > return VLC_EGENERIC;<br>> > }<br>><br>> I have a hard time seeing where the extradata is, in fact, freed.<br>><br>> And I guess we have the same issue with subtitle part.<br>><br>> With my kindest regards,<br>><br>> --<br>> Jean-Baptiste Kempf<br>> http://www.jbkempf.com/ - +33 672 704 734<br>> Sent from my Electronic Device<br>> _______________________________________________<br>> vlc-devel mailing list<br>> To unsubscribe or modify your subscription options:<br>> https://mailman.videolan.org/listinfo/vlc-devel<br>><br>-------------- next part --------------<br>An HTML attachment was scrubbed...<br>URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20150208/ede5a04b/attachment-0001.html><br><br>------------------------------<br><br>Message: 8<br>Date: Sun, 8 Feb 2015 09:50:36 +0100<br>From: Jean-Baptiste Kempf <jb@videolan.org><br>To: Mailing list for VLC media player developers<br> <vlc-devel@videolan.org><br>Subject: Re: [vlc-devel] [PATCH] avcodec: fix double free on failure<br> to open audio<br>Message-ID: <20150208085036.GA10842@videolan.org><br>Content-Type: text/plain; charset=us-ascii<br><br>On 08 Feb, Alex Converse wrote :<br>> So it's freed in avcodec_free_context() its been freed there in all<br>> versions of libav and ffmpeg that have that function. It's also freed in<br>> the current version of VLC compat but not older versions.<br><br>Got it. thanks.<br><br>With my kindest regards,<br><br>-- <br>Jean-Baptiste Kempf<br>http://www.jbkempf.com/ - +33 672 704 734<br>Sent from my Electronic Device<br><br><br>------------------------------<br><br>Subject: Digest Footer<br><br>_______________________________________________<br>vlc-devel mailing list<br>vlc-devel@videolan.org<br>https://mailman.videolan.org/listinfo/vlc-devel<br><br><br>------------------------------<br><br>End of vlc-devel Digest, Vol 93, Issue 9<br>****************************************<br></body></html>