<div dir="ltr">Hi all,<div><br></div><div>Please kindly provide comments for the patch as titled. This is not a bug fix patch but an enhancement. Especially whether the way of exposing the subtitle data to interface module is acceptable or not.</div><div><br></div><div>Thank you!</div><div><br></div><div>Goldy<br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Mar 2, 2015 at 6:00 AM, <span dir="ltr"><<a href="mailto:vlc-devel-request@videolan.org" target="_blank">vlc-devel-request@videolan.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Send vlc-devel mailing list submissions to<br>
<a href="mailto:vlc-devel@videolan.org">vlc-devel@videolan.org</a><br>
<br>
To subscribe or unsubscribe via the World Wide Web, visit<br>
<a href="https://mailman.videolan.org/listinfo/vlc-devel" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a><br>
or, via email, send a message with subject or body 'help' to<br>
<a href="mailto:vlc-devel-request@videolan.org">vlc-devel-request@videolan.org</a><br>
<br>
You can reach the person managing the list at<br>
<a href="mailto:vlc-devel-owner@videolan.org">vlc-devel-owner@videolan.org</a><br>
<br>
When replying, please edit your Subject line so it is more specific<br>
than "Re: Contents of vlc-devel digest..."<br>
<br>
<br>
Today's Topics:<br>
<br>
1. Re: gpg keys outdated and expired (Jean-Baptiste Kempf)<br>
2. [PATCH] MKV: do not hard define MKV_DEBUG (Steve Lhomme)<br>
3. [PATCH] MKV: do not hard define MKV_DEBUG (Steve Lhomme)<br>
4. [PATCH] MKV: do not hard define MKV_DEBUG (Steve Lhomme)<br>
5. [PATCH] MKV: MKV_DEBUG is a define to set, not a particular<br>
value (Steve Lhomme)<br>
6. [PATCH] Navigation enhancement for language learning (Goldy Liang)<br>
7. [PATCH] Switch from DSA to RSA keys (Rafa?l Carr?)<br>
<br>
<br>
----------------------------------------------------------------------<br>
<br>
Message: 1<br>
Date: Sun, 1 Mar 2015 12:09:58 +0100<br>
From: Jean-Baptiste Kempf <<a href="mailto:jb@videolan.org">jb@videolan.org</a>><br>
To: Mailing list for VLC media player developers<br>
<<a href="mailto:vlc-devel@videolan.org">vlc-devel@videolan.org</a>><br>
Subject: Re: [vlc-devel] gpg keys outdated and expired<br>
Message-ID: <<a href="mailto:20150301110958.GB501@videolan.org">20150301110958.GB501@videolan.org</a>><br>
Content-Type: text/plain; charset=us-ascii<br>
<br>
On 28 Feb, wax wrote :<br>
> There is no indication on the website or wiki that builds are signed<br>
> with gpg. I did notice .asc file on the ftp. [1] Eventually I found<br>
> the keys on the ftp also. [2] But to my dismay not only was the key<br>
> using 1024 DSA it was also expired. It would be nice if the download<br>
> pages made mention of a gpg sig, along with updating the key to at least<br>
> 2048 bit RSA<br>
<br>
Update the key from the servers.<br>
<br>
With my kindest regards,<br>
<br>
--<br>
Jean-Baptiste Kempf<br>
<a href="http://www.jbkempf.com/" target="_blank">http://www.jbkempf.com/</a> - <a href="tel:%2B33%20672%20704%20734" value="+33672704734">+33 672 704 734</a><br>
Sent from my Electronic Device<br>
<br>
<br>
------------------------------<br>
<br>
Message: 2<br>
Date: Mon, 2 Mar 2015 09:50:38 +0100<br>
From: Steve Lhomme <<a href="mailto:robUx4@videolabs.io">robUx4@videolabs.io</a>><br>
To: <a href="mailto:vlc-devel@videolan.org">vlc-devel@videolan.org</a><br>
Subject: [vlc-devel] [PATCH] MKV: do not hard define MKV_DEBUG<br>
Message-ID: <BLU436-SMTP1556522CA54703C3B6C41839A100@phx.gbl><br>
Content-Type: text/plain<br>
<br>
---<br>
modules/demux/mkv/mkv.hpp | 2 --<br>
1 file changed, 2 deletions(-)<br>
<br>
diff --git a/modules/demux/mkv/mkv.hpp b/modules/demux/mkv/mkv.hpp<br>
index 9cf6ccd..c052735 100644<br>
--- a/modules/demux/mkv/mkv.hpp<br>
+++ b/modules/demux/mkv/mkv.hpp<br>
@@ -99,8 +99,6 @@<br>
# include <zlib.h><br>
#endif<br>
<br>
-#define MKV_DEBUG 0<br>
-<br>
#define MATROSKA_COMPRESSION_NONE -1<br>
#define MATROSKA_COMPRESSION_ZLIB 0<br>
#define MATROSKA_COMPRESSION_BLIB 1<br>
--<br>
2.2.2<br>
<br>
<br>
<br>
------------------------------<br>
<br>
Message: 3<br>
Date: Mon, 2 Mar 2015 10:06:13 +0100<br>
From: Steve Lhomme <<a href="mailto:robUx4@videolabs.io">robUx4@videolabs.io</a>><br>
To: <a href="mailto:vlc-devel@videolan.org">vlc-devel@videolan.org</a><br>
Subject: [vlc-devel] [PATCH] MKV: do not hard define MKV_DEBUG<br>
Message-ID: <BLU437-SMTP73C5CB487A20CEA739D46B9A100@phx.gbl><br>
Content-Type: text/plain<br>
<br>
---<br>
modules/demux/mkv/mkv.hpp | 2 +-<br>
1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/modules/demux/mkv/mkv.hpp b/modules/demux/mkv/mkv.hpp<br>
index 9cf6ccd..cd80c2e 100644<br>
--- a/modules/demux/mkv/mkv.hpp<br>
+++ b/modules/demux/mkv/mkv.hpp<br>
@@ -99,7 +99,7 @@<br>
# include <zlib.h><br>
#endif<br>
<br>
-#define MKV_DEBUG 0<br>
+//#define MKV_DEBUG 0<br>
<br>
#define MATROSKA_COMPRESSION_NONE -1<br>
#define MATROSKA_COMPRESSION_ZLIB 0<br>
--<br>
2.2.2<br>
<br>
<br>
<br>
------------------------------<br>
<br>
Message: 4<br>
Date: Mon, 2 Mar 2015 10:09:27 +0100<br>
From: Steve Lhomme <<a href="mailto:robUx4@videolabs.io">robUx4@videolabs.io</a>><br>
To: <a href="mailto:vlc-devel@videolan.org">vlc-devel@videolan.org</a><br>
Subject: [vlc-devel] [PATCH] MKV: do not hard define MKV_DEBUG<br>
Message-ID: <BLU436-SMTP1677D0C068C41C31C33D9089A100@phx.gbl><br>
Content-Type: text/plain<br>
<br>
---<br>
modules/demux/mkv/mkv.hpp | 4 +++-<br>
1 file changed, 3 insertions(+), 1 deletion(-)<br>
<br>
diff --git a/modules/demux/mkv/mkv.hpp b/modules/demux/mkv/mkv.hpp<br>
index 9cf6ccd..4e2963e 100644<br>
--- a/modules/demux/mkv/mkv.hpp<br>
+++ b/modules/demux/mkv/mkv.hpp<br>
@@ -99,7 +99,9 @@<br>
# include <zlib.h><br>
#endif<br>
<br>
-#define MKV_DEBUG 0<br>
+#ifndef NDEBUG<br>
+//# define MKV_DEBUG 0<br>
+#endif<br>
<br>
#define MATROSKA_COMPRESSION_NONE -1<br>
#define MATROSKA_COMPRESSION_ZLIB 0<br>
--<br>
2.2.2<br>
<br>
<br>
<br>
------------------------------<br>
<br>
Message: 5<br>
Date: Mon, 2 Mar 2015 10:15:57 +0100<br>
From: Steve Lhomme <<a href="mailto:robUx4@videolabs.io">robUx4@videolabs.io</a>><br>
To: <a href="mailto:vlc-devel@videolan.org">vlc-devel@videolan.org</a><br>
Subject: [vlc-devel] [PATCH] MKV: MKV_DEBUG is a define to set, not a<br>
particular value<br>
Message-ID: <BLU437-SMTP79F44F46D7D79D30BDA7BF9A100@phx.gbl><br>
Content-Type: text/plain<br>
<br>
---<br>
modules/demux/mkv/virtual_segment.cpp | 4 ++--<br>
modules/demux/mkv/virtual_segment.hpp | 4 ++--<br>
2 files changed, 4 insertions(+), 4 deletions(-)<br>
<br>
diff --git a/modules/demux/mkv/virtual_segment.cpp b/modules/demux/mkv/virtual_segment.cpp<br>
index a41abb8..d9d0dc0 100644<br>
--- a/modules/demux/mkv/virtual_segment.cpp<br>
+++ b/modules/demux/mkv/virtual_segment.cpp<br>
@@ -207,7 +207,7 @@ virtual_edition_c::virtual_edition_c( chapter_edition_c * p_edit, std::vector<ma<br>
b_ordered = true;<br>
}<br>
<br>
-#if MKV_DEBUG<br>
+#ifdef MKV_DEBUG<br>
msg_Dbg( &p_main_segment->sys.demuxer, "-- RECAP-BEGIN --" );<br>
print();<br>
msg_Dbg( &p_main_segment->sys.demuxer, "-- RECAP-END --" );<br>
@@ -610,7 +610,7 @@ bool virtual_chapter_c::Leave( bool b_do_subs )<br>
return false;<br>
}<br>
<br>
-#if MKV_DEBUG<br>
+#ifdef MKV_DEBUG<br>
void virtual_chapter_c::print()<br>
{<br>
msg_Dbg( &p_segment->sys.demuxer, "*** chapter %"PRId64" - %"PRId64" (%u)",<br>
diff --git a/modules/demux/mkv/virtual_segment.hpp b/modules/demux/mkv/virtual_segment.hpp<br>
index ed40e59..46e9df2 100644<br>
--- a/modules/demux/mkv/virtual_segment.hpp<br>
+++ b/modules/demux/mkv/virtual_segment.hpp<br>
@@ -72,7 +72,7 @@ public:<br>
int64_t i_virtual_stop_time;<br>
int i_seekpoint_num;<br>
std::vector<virtual_chapter_c *> sub_chapters;<br>
-#if MKV_DEBUG<br>
+#ifdef MKV_DEBUG<br>
void print();<br>
#endif<br>
};<br>
@@ -101,7 +101,7 @@ public:<br>
private:<br>
void retimeChapters();<br>
void retimeSubChapters( virtual_chapter_c * p_vchap );<br>
-#if MKV_DEBUG<br>
+#ifdef MKV_DEBUG<br>
void print(){ for( size_t i = 0; i<chapters.size(); i++ ) chapters[i]->print(); }<br>
#endif<br>
<br>
--<br>
2.2.2<br>
<br>
<br>
<br>
------------------------------<br>
<br>
Message: 6<br>
Date: Sun, 1 Mar 2015 13:05:57 -0500<br>
From: Goldy Liang <<a href="mailto:goldyliang@gmail.com">goldyliang@gmail.com</a>><br>
To: <a href="mailto:vlc-devel@videolan.org">vlc-devel@videolan.org</a><br>
Subject: [vlc-devel] [PATCH] Navigation enhancement for language<br>
learning<br>
Message-ID:<br>
<CAMn8pu2myx-i=<a href="mailto:3Y5DJnv3znpbnC_Bqvtd5PvZcpZS_7JSdok7Q@mail.gmail.com">3Y5DJnv3znpbnC_Bqvtd5PvZcpZS_7JSdok7Q@mail.gmail.com</a>><br>
Content-Type: text/plain; charset="utf-8"<br>
<br>
Hi,<br>
<br>
Please find the patch of enhancement for language learning by adding<br>
navigation function based on subtitle data.<br>
<br>
Some background could be found in the forum thread:<br>
<a href="https://forum.videolan.org/viewtopic.php?f=18&t=122342&sid=9130404948aa59035d1fe6ff37b7194d" target="_blank">https://forum.videolan.org/viewtopic.php?f=18&t=122342&sid=9130404948aa59035d1fe6ff37b7194d</a><br>
<br>
Commit log:<br>
<br>
Navigation based on subtitle data (next/prev sentence, repeat sentence)<br>
New profile "Language learning style" for customize interface Added<br>
Slower/faster fine buttons Handle interaction between AtoB and sentence<br>
repeat<br>
<br>
More detail:<br>
- Escalated the subtitle data structure into vlc_subtitle.h<br>
- Added a field in the input thread internal data to point to the<br>
main subtitle data<br>
- Introduced API to set/reset/get the main subtitle data<br>
- Subtitle demux module invoked set to expose the subtitle data<br>
Invoked reset if subtitle unloaded (module closed)<br>
- qt4 interface module invoked get to access subtitle<br>
- qt4 interface enhanced to navigate via subtitle data, including<br>
* prev/next sentence<br>
* repeat current sentence<br>
- Menu enhanced to add related new entries<br>
- Toolbar buttons added for related functions<br>
- A new profile of customize interface named "Language learning style"<br>
- Added slower/faster fine buttons<br>
- Interaction between AtoB and sentence repeat mode<br>
<br>
Thank you for your review.<br>
<br>
Goldy<br>
-------------- next part --------------<br>
An HTML attachment was scrubbed...<br>
URL: <<a href="http://mailman.videolan.org/pipermail/vlc-devel/attachments/20150301/7e0915f7/attachment-0001.html" target="_blank">http://mailman.videolan.org/pipermail/vlc-devel/attachments/20150301/7e0915f7/attachment-0001.html</a>><br>
-------------- next part --------------<br>
A non-text attachment was scrubbed...<br>
Name: 0001-Navigation-based-on-subtitle-data-next-prev-sentence.patch<br>
Type: text/x-patch<br>
Size: 50784 bytes<br>
Desc: not available<br>
URL: <<a href="http://mailman.videolan.org/pipermail/vlc-devel/attachments/20150301/7e0915f7/attachment-0001.bin" target="_blank">http://mailman.videolan.org/pipermail/vlc-devel/attachments/20150301/7e0915f7/attachment-0001.bin</a>><br>
<br>
------------------------------<br>
<br>
Message: 7<br>
Date: Mon, 2 Mar 2015 11:03:48 +0100<br>
From: Rafa?l Carr? <<a href="mailto:funman@videolan.org">funman@videolan.org</a>><br>
To: <a href="mailto:vlc-devel@videolan.org">vlc-devel@videolan.org</a><br>
Subject: [vlc-devel] [PATCH] Switch from DSA to RSA keys<br>
Message-ID: <<a href="mailto:1425290628-1782-1-git-send-email-funman@videolan.org">1425290628-1782-1-git-send-email-funman@videolan.org</a>><br>
<br>
Change server address so old VLC versions continue to fetch a DSA signature<br>
<br>
---<br>
TODO: actually generate a new key.<br>
<br>
In person at next meeting so we can store the key on our NSA^WGemalto<br>
hardware PGP keys?<br>
<br>
include/vlc_pgpkey.h | 1 -<br>
src/misc/update.c | 4 ++--<br>
2 files changed, 2 insertions(+), 3 deletions(-)<br>
<br>
diff --git a/include/vlc_pgpkey.h b/include/vlc_pgpkey.h<br>
index ea56210..7bd357b 100644<br>
--- a/include/vlc_pgpkey.h<br>
+++ b/include/vlc_pgpkey.h<br>
@@ -5,7 +5,6 @@<br>
/* We trust this public key, and by extension, also keys signed by it. */<br>
<br>
/* NOTE:<br>
- * We need a 1024 bits DSA key.<br>
* Don't forget to upload the key to <a href="http://download.videolan.org/pub/keys/" target="_blank">http://download.videolan.org/pub/keys/</a><br>
*/<br>
<br>
diff --git a/src/misc/update.c b/src/misc/update.c<br>
index e1257b7..003ccaf 100644<br>
--- a/src/misc/update.c<br>
+++ b/src/misc/update.c<br>
@@ -83,9 +83,9 @@<br>
#endif<br>
<br>
#ifndef NDEBUG<br>
-# define UPDATE_VLC_STATUS_URL "<a href="http://update-test.videolan.org/vlc/status-win-x86" target="_blank">http://update-test.videolan.org/vlc/status-win-x86</a>"<br>
+# define UPDATE_VLC_STATUS_URL "<a href="http://update2-test.videolan.org/vlc/status-win-x86" target="_blank">http://update2-test.videolan.org/vlc/status-win-x86</a>"<br>
#else<br>
-# define UPDATE_VLC_STATUS_URL "<a href="http://update.videolan.org/vlc/status" target="_blank">http://update.videolan.org/vlc/status</a>" UPDATE_OS_SUFFIX<br>
+# define UPDATE_VLC_STATUS_URL "<a href="http://update2.videolan.org/vlc/status" target="_blank">http://update2.videolan.org/vlc/status</a>" UPDATE_OS_SUFFIX<br>
#endif<br>
<br>
/*****************************************************************************<br>
--<br>
2.3.1<br>
<br>
<br>
<br>
------------------------------<br>
<br>
Subject: Digest Footer<br>
<br>
_______________________________________________<br>
vlc-devel mailing list<br>
<a href="mailto:vlc-devel@videolan.org">vlc-devel@videolan.org</a><br>
<a href="https://mailman.videolan.org/listinfo/vlc-devel" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a><br>
<br>
<br>
------------------------------<br>
<br>
End of vlc-devel Digest, Vol 94, Issue 2<br>
****************************************<br>
</blockquote></div><br></div></div></div>