<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Sorry, I muffed the git send-mail. This is what I intended to
send...<br>
<pre wrap="">When playing live video, sometimes the arriving packets exceed the 20ms limit for displaying late pictures. I'm proposing a change to allow this value to be set on the command line.</pre>
<br>
<br>
From 9ce5a84754b992b8a61b93f79c63baec6c4867eb Mon Sep 17 00:00:00
2001<br>
From: David R Robison <a class="moz-txt-link-rfc2396E" href="mailto:david.robison@openroadsconsulting.com"><david.robison@openroadsconsulting.com></a><br>
Date: Thu, 26 Mar 2015 11:13:33 -0700<br>
Subject: [PATCH] Let the threshold for discarding late displays be
specified<br>
on the command line<br>
<br>
---<br>
src/libvlc-module.c | 7 +++++++<br>
src/video_output/video_output.c | 8 ++------<br>
2 files changed, 9 insertions(+), 6 deletions(-)<br>
<br>
diff --git a/src/libvlc-module.c b/src/libvlc-module.c<br>
index 46180f5..7293a6d 100644<br>
--- a/src/libvlc-module.c<br>
+++ b/src/libvlc-module.c<br>
@@ -482,6 +482,10 @@ static const char *const
ppsz_pos_descriptions[] =<br>
#define MOUSE_EVENTS_LONGTEXT N_( \<br>
"This enables handling of mouse clicks on the video." )<br>
<br>
+#define DISPLAY_LATE_THRESHOLD_TEXT N_("Display late threshold")<br>
+#define DISPLAY_LATE_THRESHOLD_LONGTEXT N_( \<br>
+ "VOUT Display late threshold in ms." )<br>
+<br>
/*****************************************************************************<br>
* Input<br>
****************************************************************************/<br>
@@ -1605,6 +1609,9 @@ vlc_module_begin ()<br>
add_module_list( "video-splitter", "video splitter", NULL,<br>
VIDEO_SPLITTER_TEXT, VIDEO_SPLITTER_LONGTEXT,
false )<br>
add_obsolete_string( "vout-filter" ) /* since 2.0.0 */<br>
+<br>
+ add_integer( "display-late-threshold", 20,
DISPLAY_LATE_THRESHOLD_TEXT,<br>
+ DISPLAY_LATE_THRESHOLD_LONGTEXT, true )<br>
#if 0<br>
add_string( "pixel-ratio", "1", PIXEL_RATIO_TEXT,
PIXEL_RATIO_TEXT )<br>
#endif<br>
diff --git a/src/video_output/video_output.c
b/src/video_output/video_output.c<br>
index 40701b7..3374154 100644<br>
--- a/src/video_output/video_output.c<br>
+++ b/src/video_output/video_output.c<br>
@@ -63,11 +63,6 @@ static void VoutDestructor(vlc_object_t *);<br>
*/<br>
#define VOUT_REDISPLAY_DELAY (INT64_C(80000))<br>
<br>
-/**<br>
- * Late pictures having a delay higher than this value are
thrashed.<br>
- */<br>
-#define VOUT_DISPLAY_LATE_THRESHOLD (INT64_C(20000))<br>
-<br>
/* Better be in advance when awakening than late... */<br>
#define VOUT_MWAIT_TOLERANCE (INT64_C(4000))<br>
<br>
@@ -786,7 +781,8 @@ static int
ThreadDisplayPreparePicture(vout_thread_t *vout, bool reuse, bool
fra<br>
if (is_late_dropped &&
!decoded->b_force) {<br>
const mtime_t predicted = mdate() + 0; /* TODO
improve */<br>
const mtime_t late = predicted -
decoded->date;<br>
- if (late > VOUT_DISPLAY_LATE_THRESHOLD) {<br>
+ long display_late = var_InheritInteger(vout,
"display-late-threshold") * 1000;<br>
+ if (late > display_late) {<br>
msg_Warn(vout, "picture is too late to be
displayed (missing %"PRId64" ms)", late/1000);<br>
picture_Release(decoded);<br>
vout_statistic_AddLost(&vout->p->statistic, 1);<br>
-- <br>
1.9.1<br>
<br>
<br>
<div class="moz-signature">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<img moz-do-not-send="false"
src="cid:part1.09090806.04050502@openroadsconsulting.com">
<p
style="margin-top:0pt;margin-right:0pt;margin-bottom:.0001pt;margin-left:0pt;"><span
style="font-size:10.0pt;font-family:"Arial","sans-serif";color:red">----------------------------------------------------------------------------</span></p>
<p
style="margin-top:0pt;margin-right:0pt;margin-bottom:.0001pt;margin-left:0pt;"><span
style="font-size:10.0pt;font-family:"Arial","sans-serif";color:red;"
lang="EN-GB">David R Robison</span></p>
<p
style="margin-top:0pt;margin-right:0pt;margin-bottom:.0001pt;margin-left:0pt;"><b><span
style="font-size:10.0pt;font-family:"Arial","sans-serif";color:#002060;"
lang="EN-GB">Principal Systems Engineer</span></b></p>
<p
style="margin-top:0pt;margin-right:0pt;margin-bottom:.0001pt;margin-left:0pt;"><span
style="font-size:10.0pt;font-family:"Arial","sans-serif";color:#1F497D;"
lang="EN-GB">+1 757 546 3401 (o)</span></p>
<p
style="margin-top:0pt;margin-right:0pt;margin-bottom:.0001pt;margin-left:0pt;"><span
style="font-size:10.0pt;font-family:"Arial","sans-serif";color:#1F497D;
\" lang="EN-GB">+1 757 286 0022 (m)</span></p>
<p
style="margin-top:0pt;margin-right:0pt;margin-bottom:.0001pt;margin-left:0pt;t"><span
style="font-size:10.0pt;font-family:"Arial","sans-serif";"
lang="EN-GB"><a
href="mailto:david.robison@openroadsconsulting.com">david.robison@openroadsconsulting.com</a></span></p>
<p
style="margin-top:0pt;margin-right:0pt;margin-bottom:.0001pt;margin-left:0pt;><a
href="http://www.openroadsconsulting.com/"><span
lang=EN-GB style="
font-size:10.0pt;font-family:"arial","sans-serif";'=""><a class="moz-txt-link-abbreviated" href="http://www.openroadsconsulting.com">www.openroadsconsulting.com</a></p>
<p
style="margin-top:0pt;margin-right:0pt;margin-bottom:.0001pt;margin-left:0pt;"><span
style="font-size:10.0pt;font-family:"Arial","sans-serif";color:red">----------------------------------------------------------------------------</span></p>
<p
style="margin-top:0pt;margin-right:0pt;margin-bottom:.0001pt;margin-left:0pt;"><span
style="font-size:10.0pt;font-family:"Arial","sans-serif";color:red;"
lang="EN-GB">Open Roads Consulting </span></p>
<p
style="margin-top:0pt;margin-right:0pt;margin-bottom:.0001pt;margin-left:0pt;"><span
style="font-size:10.0pt;font-family:"Arial","sans-serif";color:red;"
lang="EN-GB">A Q-Free Company</span></p>
<p
style="margin-top:0pt;margin-right:0pt;margin-bottom:.0001pt;margin-left:0pt;"><span
style="font-size:10.0pt;font-family:"Arial","sans-serif";color:#002060;"
lang="EN-GB">103 Watson Rd. Chesapeake VA 23320</span></p>
</div>
<div class="moz-cite-prefix">On 3/26/2015 2:18 PM, David R Robison
wrote:<br>
</div>
<blockquote
cite="mid:1427393894-33923-1-git-send-email-david.robison@openroadsconsulting.com"
type="cite">
<pre wrap="">When playing live video, sometimes the arriving packets exceed the 20ms limit for displaying late pictures. I'm proposing a change to allow this value to be set on the command line.
This email communication (including any attachments) may contain confidential and/or privileged material intended solely for the individual or entity to which it is addressed.
If you are not the intended recipient, please delete this email immediately.
_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
<a class="moz-txt-link-freetext" href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a>
</pre>
</blockquote>
<br>
<BR />
<BR />
<HR />
This email communication (including any attachments) may contain confidential and/or privileged material intended solely for the individual or entity to which it is addressed.<BR />
If you are not the intended recipient, please delete this email immediately.<BR />
</body>
</html>