<div dir="ltr"><div>From: Zhao Zhili <<a href="mailto:wantlamy@gmail.com">wantlamy@gmail.com</a>><br></div><div><br></div><div>Sorry, this is my first time to submit a patch. And thanks to the stupid GFW, I don't know</div><div>how to make mutt or git-send-mail work with gmail. I have changed the gmail setting on</div><div>browser, hope it meets the requirement now.</div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jun 9, 2015 at 12:55 AM, Rémi Denis-Courmont <span dir="ltr"><<a href="mailto:remi@remlab.net" target="_blank">remi@remlab.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> Nihao,<br>
<span class=""><br>
Le mardi 09 juin 2015, 00:45:01 Quink a écrit :<br>
> When one of item->psz_name and item->psz_description is not NULL, I think<br>
> there is<br>
> memory leak.<br>
<br>
</span>This looks correct, but I think the VideoLAN foundation now requires a proper<br>
author name to attribute the copyright to.<br>
<div class="HOEnZb"><div class="h5"><br>
><br>
> ---<br>
> lib/audio.c | 2 ++<br>
> 1 file changed, 2 insertions(+)<br>
><br>
> diff --git a/lib/audio.c b/lib/audio.c<br>
> index 4e0bacc..7901c64 100644<br>
> --- a/lib/audio.c<br>
> +++ b/lib/audio.c<br>
> @@ -86,6 +86,8 @@ libvlc_audio_output_t *<br>
> item->psz_description = strdup( module_get_name( module, true ) );<br>
> if( unlikely(item->psz_name == NULL || item->psz_description ==<br>
> NULL) )<br>
> {<br>
> + free( item->psz_name );<br>
> + free( item->psz_description );<br>
> free( item );<br>
> goto error;<br>
> }<br>
<br>
--<br>
</div></div><span class="HOEnZb"><font color="#888888">Rémi Denis-Courmont<br>
<a href="http://www.remlab.net/" target="_blank">http://www.remlab.net/</a><br>
<br>
</font></span></blockquote></div><br></div></div>