<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">Am 02.10.2016 um 05:00 schrieb Vittorio Giovara <<a href="mailto:vittorio.giovara@gmail.com" class="">vittorio.giovara@gmail.com</a>>:</div><br class="Apple-interchange-newline"><div class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">On Sat, Oct 1, 2016 at 9:59 PM, Rémi Denis-Courmont <</span><a href="mailto:remi@remlab.net" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">remi@remlab.net</a><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">> wrote:</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">Le samedi 1 octobre 2016, 21:41:57 Vittorio Giovara a écrit :<br class=""><blockquote type="cite" class="">---<br class="">I am not sure this is the right way, but the default configure enable<br class="">libpulse which uses vlc_tdestroy without linking the core.<br class="">Vittorio<br class=""><br class="">configure.ac | 2 ++<br class="">modules/services_discovery/Makefile.am | 3 +++<br class="">2 files changed, 5 insertions(+)<br class=""><br class="">diff --git a/configure.ac b/configure.ac<br class="">index 2e6eb2b..9b8a0e9 100644<br class="">--- a/configure.ac<br class="">+++ b/configure.ac<br class="">@@ -808,6 +808,8 @@ dnl<br class=""><br class="">dnl POSIX<br class="">AC_CHECK_HEADERS([arpa/inet.h pthread.h search.h sys/shm.h sys/socket.h<br class="">sys/uio.h]) +AM_CONDITIONAL([HAVE_NOTDESTROY], [test "$have_search_h" =<br class="">"yes" && test "$have_tdestroy" = "no"]) +<br class="">AC_CHECK_HEADERS([net/if.h], [], [],<br class="">[<br class="">#include <sys/types.h><br class="">diff --git a/modules/services_discovery/Makefile.am<br class="">b/modules/services_discovery/Makefile.am index 2bdc75f..41cdc02 100644<br class="">--- a/modules/services_discovery/Makefile.am<br class="">+++ b/modules/services_discovery/Makefile.am<br class="">@@ -35,6 +35,9 @@ EXTRA_LTLIBRARIES += libupnp_plugin.la<br class="">sd_LTLIBRARIES += $(LTLIBupnp)<br class=""><br class="">libpulselist_plugin_la_SOURCES = services_discovery/pulse.c<br class="">+if HAVE_NOTDESTROY<br class="">+libpulselist_plugin_la_SOURCES += ../src/extras/tdestroy.c<br class="">+endif<br class="">libpulselist_plugin_la_CFLAGS = $(AM_CFLAGS) $(PULSE_CFLAGS)<br class="">libpulselist_plugin_la_LIBADD = libvlc_pulse.la $(PULSE_LIBS)<br class="">if HAVE_PULSE<br class=""></blockquote><br class="">This feels very wrong and in any case, it is not supported properly by<br class="">automake, so no.<br class=""><br class="">—</blockquote></div></blockquote><div><br class=""></div><div>Hi,</div><div><br class=""></div><div>I think the compat for that function is somehow broken. Its defined in vlc_fixups.h (with #define tdestroy vlc_tdestroy), but not really part of compat. OTOH, there is tdestroy.c in compat, which defines a replacement for destroy, but not vlc_tdestroy.</div><div>I do not know why there is yet another tdestroy replacement inside the core. </div><div><br class=""></div><div>Maybe switching to the compat replacement is the better way here?</div><br class=""><blockquote type="cite" class=""><div class=""><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">Yeah it's pretty ugly.</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">Would it be ok to disable pulse by default on OSX then?</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""></div></blockquote><div><br class=""></div><div>I never tested pulse on macOS, so I would not mind. I see that macports has a pulse variant, but that seems for pulse audio output mainly.</div><div><br class=""></div><div>Best,</div><div>David</div></div></body></html>