<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta http-equiv="Content-Style-Type" content="text/css" />
<meta name="generator" content="pandoc" />
<title></title>
<style type="text/css">code{white-space: pre;}</style>
</head>
<body>
<p>Hi,</p>
<p>On 2016-10-14 18:32, Hugo Beauzée-Luyssen wrote:</p>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> On 10/14/2016 06:26 PM, Rémi Denis-Courmont wrote:</code></pre>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> [ ... ]</code></pre>
<p>That’s a fair point. Although int a = var_InheritInteger should and will trigger a compiler warning, I’m afraid fixing all call sites could be long and painfull, if not error prone… I have no strong opinion here, beside the fact that without this commit (or with Filip recent commit, enforcing the check), any int64 passed through command line will be clamped in between the wrong values.</p>
</blockquote>
</blockquote>
<p>Another way of fixing the described issues is to only apply <code>VLC_VAR_SETMINMAX</code> if the associated module configuration for int and float variables, respectivally, differ from <code>[0,0]</code> and <code>[NaN,NaN]</code>.</p>
<p>That way we can set the default to the mentioned ranges (because it certainly does not make sense to specify either <code>[0,0]</code> as range, or <code>[NaN,NaN]</code>.</p>
<p>See attached patch.</p>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> Regards,
_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
https://mailman.videolan.org/listinfo/vlc-devel</code></pre>
</blockquote>
</body>
</html>