<p dir="ltr">Hi Pyry,</p>
<p dir="ltr">On Oct 21, 2016 15:32, "Pyry Kontio" <<a href="mailto:pyry.kontio@drasa.eu">pyry.kontio@drasa.eu</a>> wrote:<br>
><br>
> The bootstrap script that outputs which binary tools need to be installed, incorrectly<br>
> detects that Protocol Buffers 3.1 is a compatible version with 2.6. I changed the<br>
> check on the major version number to require it to be same, not just bigger,<br>
> since changes on the major version numbers might be breaking changes, as was the case<br>
> here.<br>
> ---<br>
> extras/tools/bootstrap | 2 +-<br>
> 1 file changed, 1 insertion(+), 1 deletion(-)<br>
><br>
> diff --git a/extras/tools/bootstrap b/extras/tools/bootstrap<br>
> index 9666436..95870fa 100755<br>
> --- a/extras/tools/bootstrap<br>
> +++ b/extras/tools/bootstrap<br>
> @@ -60,7 +60,7 @@ else<br>
> needminor=`echo $2|cut -d. -f2`<br>
> needmicro=`echo $2|cut -d. -f3`<br>
> [ -z "$needmicro" ] && needmicro=0<br>
> - if [ "$needmajor" -gt "$gotmajor" \<br>
> + if [ "$needmajor" -ne "$gotmajor" \<br>
> -o "$needmajor" -eq "$gotmajor" -a "$needminor" -gt "$gotminor" \<br>
> -o "$needmajor" -eq "$gotmajor" -a "$needminor" -eq "$gotminor" -a "$needmicro" -gt "$gotmicro" ]<br>
> then<br>
> --</p>
<p dir="ltr">Oooh! Nice catch!</p>
<p dir="ltr">Can we be sure that all the other tools only bump major for a breaking change, though? If so, LGTM.</p>
<p dir="ltr">----<br>
Sean McGovern - +1 613 862 6507</p>