<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta http-equiv="Content-Style-Type" content="text/css" />
<meta name="generator" content="pandoc" />
<title></title>
<style type="text/css">code{white-space: pre;}</style>
</head>
<body>
<p>Hi Filip (aka. myself),</p>
<p>Once again your forgot to honor the <em>coding-style</em> of the file which the patch applies to, as a helpful reminder what follows is an ascii-fish (that will eat you if you continue to forgot what has been mentioned).</p>
<pre><code>[bug] /"*._ _
.-*'` `*-.._.-'/
< * )) , (
`*-._`._(__.--*"`.\
src: http://www.ascii-code.com/ascii-art/animals/fish.php</code></pre>
<p>On 2016-10-28 08:54, Filip Roséen wrote:</p>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> Given that module_InitDynamic can fail and return a NULL pointer to
signal the error, we cannot unconditionally set data-members of the
referred to vlc_plugin_t.
These changes fixes the issue by introducing an explicit branch
related to initialization.
---
src/modules/bank.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
...</code></pre>
</blockquote>
<p>Attached to this email is a patch where the original <em>coding-style</em> is honored.</p>
<p>Best Regards,<br />
Filip</p>
</body>
</html>