<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta http-equiv="Content-Style-Type" content="text/css" />
<meta name="generator" content="pandoc" />
<title></title>
<style type="text/css">code{white-space: pre;}</style>
</head>
<body>
<p>Hi Rémi,</p>
<p>On 2016-10-28 15:15, Rémi Denis-Courmont wrote:</p>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> Le perjantaina 28. lokakuuta 2016, 10.49.44 EEST Filip Roséen a écrit :</code></pre>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> According to RFC3986, the port specifier does not have to contain
digits following the colon. This means that "http://example.com:" is a
valid URI, and that the relevant test should not be within the
"Invalid URIs"-group.</code></pre>
</blockquote>
<pre><code> You need to fix vlc_UrlParse() too. It returns an error if 'end == next'.</code></pre>
</blockquote>
<p>Yeah, as <em>tguillem</em> said I should have used another order for the patches - sorry about that!</p>
<ul>
<li>Should I rebase and resend them in the correct order? Basically <code>4/4</code> should be <code>#1</code>, and the other patches should follow that one.</li>
</ul>
<p>Best Regards,<br />
Filip</p>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> ---
src/test/url.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/test/url.c b/src/test/url.c
index 2ed99d5..ffb073c 100644
--- a/src/test/url.c
+++ b/src/test/url.c
@@ -268,6 +268,8 @@ int main (void)
"/", NULL);
test_url_parse("http://[2001:db8::1]", "http", NULL, NULL,
"2001:db8::1", 0, NULL, NULL);
+ test_url_parse("http://example.com:", "http", NULL, NULL,
"example.com", 0, + NULL, NULL);
test_url_parse("protocol://john:doe@1.2.3.4:567", "protocol", "john",
"doe", "1.2.3.4", 567, NULL, NULL); test_url_parse("http://a.b/?opt=val",
"http", NULL, NULL, "a.b", 0, "/", "opt=val");
test_url_parse("p://u:p@host:123/a/b/c?o=v", "p", "u", "p", "host", 123,
"/a/b/c", "o=v"); @@ -300,8 +302,6 @@ int main (void)
/* Invalid URIs */
test_url_parse("p://G a r b a g e", "p", NULL, NULL, NULL, 0, NULL,
NULL); test_url_parse("p://h/G a r b a g e", "p", NULL, NULL, "h", 0, NULL,
NULL); - test_url_parse("http://example.com:", "http", NULL, NULL,
"example.com", 0, - NULL, NULL);
test_url_parse("http://example.com:123xyz", "http", NULL, NULL,
"example.com", 123, NULL, NULL);</code></pre>
</blockquote>
<pre><code> --
Rémi Denis-Courmont
Nonsponsored VLC developer
http://www.remlab.net/CV.pdf
_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
https://mailman.videolan.org/listinfo/vlc-devel</code></pre>
</blockquote>
</body>
</html>