<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">Am 01.11.2016 um 16:09 schrieb Rémi Denis-Courmont <<a href="mailto:remi@remlab.net" class="">remi@remlab.net</a>>:</div><br class="Apple-interchange-newline"><div class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">Le tiistaina 1. marraskuuta 2016, 15.12.29 EET David Fuhrmann a écrit :</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">vlc | branch: master | David Fuhrmann <<a href="mailto:dfuhrmann@videolan.org" class="">dfuhrmann@videolan.org</a>> | Tue Nov 1<br class="">14:35:08 2016 +0100| [784ab6ce693675fb554060d1e1f8d194c354e3ff] |<br class="">committer: David Fuhrmann<br class=""><br class="">tests/tls: Disable checks for ALPN on apple platforms<br class=""></blockquote><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">Disabling tests because of a true positive failure? You have got to be<span class="Apple-converted-space"> </span></span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">kidding. Even a fresh IT graduate would know better than that.</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""></div></blockquote><div><br class=""></div><div>Hello,</div><div><br class=""></div><div>I disabled a test for a distinct feature which is not implemented in the securetransport module and thus not available on all Apple platforms for its default configuration. This feature will not be added in the near future as the underlying library just does not support that.</div><div><br class=""></div><div>You are arguing that you want to use test failures to track missing functionality. I completely disagree with that. For such kind of things, we have trac. If you want to have a feature in, create a trac ticket and set the priority to high, if its important. (Which I believe is not in this case.) But do not misuse tests.</div><div>But if the whole team sees that differently, I’m happy to hear your arguments.</div><div><br class=""></div><div>Seeing that, I see no problem with disabling ALPN related tests.</div><br class=""><blockquote type="cite" class=""><div class=""><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">On Apple platforms, ALPN does not work as securetransport does<br class="">not provide any public API for that. So do not check for that<br class="">feature until support is added.<br class=""><br class=""><blockquote type="cite" class=""><a href="http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=784ab6ce693675fb554" class="">http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=784ab6ce693675fb554</a><br class="">060d1e1f8d194c354e3ff<br class=""></blockquote>---<br class=""><br class="">test/modules/misc/tls.c | 4 ++++<br class="">1 file changed, 4 insertions(+)<br class=""><br class="">diff --git a/test/modules/misc/tls.c b/test/modules/misc/tls.c<br class="">index 60898c6..a2ddbf0 100644<br class="">--- a/test/modules/misc/tls.c<br class="">+++ b/test/modules/misc/tls.c<br class="">@@ -201,9 +201,13 @@ int main(void)<br class=""> answer = 1;<br class=""> val = securepair(&th, &tls, alpnv, &alp);<br class=""> assert(val == 0);<br class="">+<br class="">+ /* SecureTransport, used on apple platforms, does not support ALPN */<br class="">+#ifndef __APPLE__<br class=""> assert(alp != NULL);<br class=""> assert(!strcmp(alp, "bar"));<br class=""> free(alp);<br class="">+#endif<br class=""></blockquote><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">Oh and not only it removes a valid test cases, but it obviously introduces a<span class="Apple-converted-space"> </span></span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">leak if GnuTLS is used (which is perfectly possible on MacOS).</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""></div></blockquote><div><br class=""></div><div>Indeed, I’ll fix that.</div><div><br class=""></div><div>BR. David</div></div></body></html>