<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta http-equiv="Content-Style-Type" content="text/css" />
<meta name="generator" content="pandoc" />
<title></title>
<style type="text/css">code{white-space: pre;}</style>
</head>
<body>
<p>Hi David,</p>
<p>On 2016-11-01 15:12, David Fuhrmann wrote:</p>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> vlc | branch: master | David Fuhrmann <dfuhrmann@videolan.org> |
Tue Nov 1 15:10:50 2016 +0100| [d70331b13ca5c65bb1b16b7d97a8c23bf7e7d86f] |
committer: David Fuhrmann
macosx: advanced prefs: only choose slider if we have limits set
The RangedXXControls only make much sense if we have sensible
limits.</code></pre>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=d70331b13ca5c65bb1b16b7d97a8c23bf7e7d86f</code></pre>
</blockquote>
</blockquote>
<p>The default range for integer configurations is <code>(INT64_MIN, INT64_MAX)</code> after <code>e908026</code>, so the commit in which this email is a reply to should (probably) be modified to use these values(?).</p>
<p>I also noted the usage of <code>&&</code> instead of <code>||</code> in the commit, meaning that a module having a range such as <code>(x, INT64_MAX)</code> or <code>(INT64_MIN, x)</code>, where <code>x</code> is arbitrary but not <code>INT64_MIN</code> and <code>INT64_MAX</code> respectively, would not have a slider for input (even though it has an explicit range set).</p>
<p>Attached is a patch that takes care of what I wrote above, though:</p>
<ul>
<li><p>Is it a concious decision to use <code>INT32_</code> instead of <code>INT64_</code>?</p></li>
<li><p>If so, does it not make more sense to check the absolute difference between <em>min</em> and <em>max</em> (to only display a slider for <em>“sensible limits”</em>?</p></li>
</ul>
<p>Best Regards,<br />
Filip Roséen</p>
</body>
</html>