<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hi Filip,<div class=""><br class=""></div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">Am 02.11.2016 um 00:48 schrieb Filip Roséen <<a href="mailto:filip@atch.se" class="">filip@atch.se</a>>:</div><br class="Apple-interchange-newline"><div class=""><p style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">Hi David,</p><p style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">On 2016-11-01 15:12, David Fuhrmann wrote:</p><blockquote style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; color: rgb(80, 0, 80);" class=""><pre class=""><code style="white-space: pre;" class=""> vlc | branch: master | David Fuhrmann <<a href="mailto:dfuhrmann@videolan.org" class="">dfuhrmann@videolan.org</a>> |
Tue Nov 1 15:10:50 2016 +0100| [d70331b13ca5c65bb1b16b7d97a8c23bf7e7d86f] |
committer: David Fuhrmann
macosx: advanced prefs: only choose slider if we have limits set
The RangedXXControls only make much sense if we have sensible
limits.</code></pre><blockquote style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; color: rgb(80, 0, 80);" class=""><pre class=""><code style="white-space: pre;" class=""> <a href="http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=d70331b13ca5c65bb1b16b7d97a8c23bf7e7d86f" class="">http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=d70331b13ca5c65bb1b16b7d97a8c23bf7e7d86f</a></code></pre></blockquote></blockquote><p style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">The default range for integer configurations is<span class="Apple-converted-space"> </span><code style="white-space: pre;" class="">(INT64_MIN, INT64_MAX)</code><span class="Apple-converted-space"> </span>after<span class="Apple-converted-space"> </span><code style="white-space: pre;" class="">e908026</code>, so the commit in which this email is a reply to should (probably) be modified to use these values(?).</p><p style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">I also noted the usage of<span class="Apple-converted-space"> </span><code style="white-space: pre;" class="">&&</code><span class="Apple-converted-space"> </span>instead of<span class="Apple-converted-space"> </span><code style="white-space: pre;" class="">||</code><span class="Apple-converted-space"> </span>in the commit, meaning that a module having a range such as<span class="Apple-converted-space"> </span><code style="white-space: pre;" class="">(x, INT64_MAX)</code><span class="Apple-converted-space"> </span>or<span class="Apple-converted-space"> </span><code style="white-space: pre;" class="">(INT64_MIN, x)</code>, where<span class="Apple-converted-space"> </span><code style="white-space: pre;" class="">x</code><span class="Apple-converted-space"> </span>is arbitrary but not<span class="Apple-converted-space"> </span><code style="white-space: pre;" class="">INT64_MIN</code><span class="Apple-converted-space"> </span>and<span class="Apple-converted-space"> </span><code style="white-space: pre;" class="">INT64_MAX</code><span class="Apple-converted-space"> </span>respectively, would not have a slider for input (even though it has an explicit range set).</p><p style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">Attached is a patch that takes care of what I wrote above, though:</p><ul style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><li class=""><p class="">Is it a concious decision to use<span class="Apple-converted-space"> </span><code style="white-space: pre;" class="">INT32_</code><span class="Apple-converted-space"> </span>instead of<span class="Apple-converted-space"> </span><code style="white-space: pre;" class="">INT64_</code>?</p></li><li class=""><p class="">If so, does it not make more sense to check the absolute difference between<span class="Apple-converted-space"> </span><em class="">min</em><span class="Apple-converted-space"> </span>and<span class="Apple-converted-space"> </span><em class="">max</em><span class="Apple-converted-space"> </span>(to only display a slider for<span class="Apple-converted-space"> </span><em class="">“sensible limits”</em>?</p></li></ul></div></blockquote><div>Yes, this was the main reason, but I’m not sure what is the best way. Of course we can think about more sensibly defining „good limits“. I think a slider ranging from INT64_MIN to INT64_MAX - 1 just does not make much sense.</div><div><br class=""></div><div>After I looked at some ranges, It seems we define them quite diversely, ranging from small ranges, to something like [0,INT32_MAX].</div><div><br class=""></div><div>On the other hand, the current code does not support values > sizeof(int) at all, as the controls store use int for the getters and setters.</div><div><br class=""></div><div>What is your opinion about that topic?</div><div><br class=""></div><div>Best regards,</div><div>David</div></div></div></body></html>