<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta http-equiv="Content-Style-Type" content="text/css" />
<meta name="generator" content="pandoc" />
<title></title>
<style type="text/css">code{white-space: pre;}</style>
</head>
<body>
<p>Hi Francois,</p>
<p>On 2016-11-04 11:15, Francois Cartegnie wrote:</p>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> Le 01/11/2016 à 03:23, Filip Roséen a écrit :</code></pre>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> - msg_Dbg( p_dec, "found NAL_PPS (pps_id=%d sps_id=%d)", p_pps->i_id, p_pps->i_sps_id );
+ {
+ msg_Dbg( p_dec, "found NAL_PPS (pps_id=%" PRIu32 " sps_id=%" PRIu32 ")",
+ p_pps->i_id, p_pps->i_sps_id );
+ }
+
p_sys->b_pps = true;</code></pre>
</blockquote>
<pre><code> That fix in incorrect and allows overflows, thus not detecting broken
SPS, which would be passed to decoder.</code></pre>
</blockquote>
<p>If you do not mind me asking;</p>
<ul>
<li>where does the patch allow for an overflow to occur?</li>
</ul>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> Also keeps bloating structs without reason. No id will ever require more
than 1 byte.</code></pre>
</blockquote>
<p>Yes, one could have split up the read and assignment to the structure, but I was looking for the least intrusive change (that would still allow for correct behavior) while also honoring the specification in terms of how things are structured.</p>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> Francois</code></pre>
</blockquote>
</body>
</html>