<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta http-equiv="Content-Style-Type" content="text/css" />
<meta name="generator" content="pandoc" />
<title></title>
<style type="text/css">code{white-space: pre;}</style>
</head>
<body>
<p>Hi Francois,</p>
<p>On 2016-11-16 11:58, Francois Cartegnie wrote:</p>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> Le 16/11/2016 à 11:37, Filip Roséen a écrit :
f165592 100644</code></pre>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> --- a/modules/demux/mp4/libmp4.h
+++ b/modules/demux/mp4/libmp4.h
@@ -1176,6 +1176,7 @@ typedef struct
typedef struct
{
char *psz_text;
+ uint64_t i_length;</code></pre>
</blockquote>
<pre><code> ReadBox_String will never succeed with more than SIZE_MAX.</code></pre>
</blockquote>
<p>the usage of <code>uint64_t</code> was simply to provide consistency with other boxes that uses <code>uint64_t</code> for the length (like <code>MP4_Box_s</code>). As such I thought it would be appropriate to use the same type for the <em>data-member</em> in question.</p>
<p>Also, <code>MP4_READBOX_ENTER_PARTIAL</code> uses <code>int64_t</code> for <code>i_read</code>, though given that the <code>i_length</code> can never be negative I simply used <code>uint64_t</code> to reflect the <em>value-type</em> of <code>i_read</code>.</p>
<p>If the entire patch-set gets the desired <em>LGTM</em> I can attach an update patch to this one where a potentially smaller type is used. I do not mind such change if one feels it is appropriate.</p>
</body>
</html>