<div dir="ltr">I already created the patches via "git format-patch" and sent the emails via "git send-email"...<div class="gmail_extra"><br></div><div class="gmail_extra">Further, I used meaningful commit messages in the subject and set my name and email correctly...</div><div class="gmail_extra"><br></div><div class="gmail_extra">I am nearly waiting a month for this small commit to be merged...</div><div class="gmail_extra"><br></div><div class="gmail_extra">Seems to be a really complicated process:</div><div class="gmail_extra"><ul><li>Preparing the build environment: Several hours with slow internet</li><li>Understanding the code and finding files which need changes: One to two hours</li><li>Writing the fix and testing it: Half an hour</li><li>Trying to have this fix applied: More than a month...</li></ul><div><div class="m_-1986888314015099798gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div dir="ltr"><div><div style="font-size:12.8000001907349px"><b><font color="#999999">Mit freundlichen Grüßen / Kind regards,</font></b></div><div style="font-size:12.8000001907349px"><font color="#999999">Marcel Schnirring<br></font></div></div></div></div></div></div>
<br><div class="gmail_quote">On Thu, Dec 15, 2016 at 8:22 PM, Filip Roséen <span dir="ltr"><<a href="mailto:filip@atch.se" target="_blank">filip@atch.se</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><u></u>
<div>
<p>Hi Marcel,</p><span>
<p>On 2016-12-15 16:32, Marcel Schnirring wrote:</p>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> After another week passt, asking again for the state of my patch...</code></pre>
</blockquote>
</span><p>Please see the below linked reply (the contents still applies):</p>
<ul>
<li><a href="https://mailman.videolan.org/pipermail/vlc-devel/2016-December/110845.html" target="_blank">https://mailman.videolan.org/p<wbr>ipermail/vlc-devel/2016-Decemb<wbr>er/110845.html</a></li>
</ul>
<p>I do not have commit access myself, and as such I can only provide recommendations in terms of getting things merged into the codebase.</p>
<p>Submitting your work to <code>vlc-devel</code> in the way which is intended would surely help merging it, especially given that your previous emails does not include a proper commit message (nor does it include the relevant information in regards of <em>Author</em>, etc).</p>
<p>Best Regards,<br>
Filip Roséen</p>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> *Mit freundlichen Grüßen / Kind regards,*
Marcel Schnirring
*Heilbronner Strasse 36*
*76131 Karlsruhe*
*Deutschland / Germany*
*Email: <a href="mailto:ms@marcel-schnirring.de" target="_blank">ms@marcel-schnirring.de</a> <<a href="mailto:ms@marcel-schnirring.de" target="_blank">ms@marcel-schnirring.de</a>>*
*Mobile: <a href="tel:+49%20178%201983761" value="+491781983761" target="_blank">(+49) 178 198 37 61</a>*
On Thu, Dec 8, 2016 at 10:21 PM, Marcel Schnirring <<a href="mailto:ms@marcel-schnirring.de" target="_blank">ms@marcel-schnirring.de</a>>
wrote:</code></pre><div><div class="m_-1986888314015099798h5">
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> ---
include/vlc_playlist.h | 3 ++-
src/playlist/sort.c | 14 ++++++++++++--
2 files changed, 14 insertions(+), 3 deletions(-)
diff --git a/include/vlc_playlist.h b/include/vlc_playlist.h
index 6e42cb5..6a65c80 100644
--- a/include/vlc_playlist.h
+++ b/include/vlc_playlist.h
@@ -186,7 +186,8 @@ struct playlist_t
DEF( SORT_DESCRIPTION )\
DEF( SORT_RATING )\
DEF( SORT_URI )\
- DEF( SORT_DISC_NUMBER )
+ DEF( SORT_DISC_NUMBER )\
+ DEF( SORT_DATE )
#define DEF( s ) s,
enum
diff --git a/src/playlist/sort.c b/src/playlist/sort.c
index 588bd35..f241167 100644
--- a/src/playlist/sort.c
+++ b/src/playlist/sort.c
@@ -226,12 +226,22 @@ SORTFN( SORT_ALBUM, first, second )
return i_ret;
}
+SORTFN( SORT_DATE, first, second )
+{
+ int i_ret = meta_sort( first, second, vlc_meta_Date, true );
+ /* Items came from the same date: compare the albums */
+ if( i_ret == 0 )
+ i_ret = proto_SORT_ALBUM( first, second );
+
+ return i_ret;
+}
+
SORTFN( SORT_ARTIST, first, second )
{
int i_ret = meta_sort( first, second, vlc_meta_Artist, false );
- /* Items came from the same artist: compare the albums */
+ /* Items came from the same artist: compare the dates */
if( i_ret == 0 )
- i_ret = proto_SORT_ALBUM( first, second );
+ i_ret = proto_SORT_DATE( first, second );
return i_ret;
}
--
2.10.2.windows.1</code></pre>
</blockquote>
</div></div></blockquote>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> ______________________________<wbr>_________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
<a href="https://mailman.videolan.org/listinfo/vlc-devel" target="_blank">https://mailman.videolan.org/l<wbr>istinfo/vlc-devel</a></code></pre>
</blockquote>
</div>
<br>______________________________<wbr>_________________<br>
vlc-devel mailing list<br>
To unsubscribe or modify your subscription options:<br>
<a href="https://mailman.videolan.org/listinfo/vlc-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/l<wbr>istinfo/vlc-devel</a><br></blockquote></div><br></div></div>