<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta http-equiv="Content-Style-Type" content="text/css" />
<meta name="generator" content="pandoc" />
<title></title>
<style type="text/css">code{white-space: pre;}</style>
</head>
<body>
<p>Hi Francois,</p>
<p>On 2017-01-12 16:26, Francois Cartegnie wrote:</p>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> Le 12/01/2017 à 16:18, Filip Roséen a écrit :</code></pre>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> The above looks very very odd. Given that it looks like you are trying
to extract hours, minutes, and seconds, something like the below would
be correct:
h = i_time / 3600;
m = i_time % 3600 / 60;
s = i_time % 60;
It is also worth noting that I personally feel that readability is
harmed when variable declarations are separated from their
initialization for no apparent reason.</code></pre>
</blockquote>
<pre><code> I haven't really tested for over second timings. But min seems
incorrect, yes.</code></pre>
</blockquote>
<p>Seconds is also wrong, and the usage of <code>CLOCK_FREQ</code> should make everything turn out weird.</p>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> + /* remove */
+ continue;
+ }</code></pre>
</blockquote>
<pre><code> For all cases where `strcmp` is used above, `strcasecmp` might make
more sense (given that the case of the attributes are not strictly
limited to lower-case, afaik)?</code></pre>
</blockquote>
<pre><code> Since when ? That's not HTML 1.0 crap.
XML is case sensitive. We already fail on namespaces, let's not add more
broken matches.</code></pre>
</blockquote>
<p>I had some vague memory of ttml differing from the xml spec in that regard, but now that I gave the RFC a skim through that does not seem to be the case.</p>
<p>Sorry.</p>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> Francois
_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
https://mailman.videolan.org/listinfo/vlc-devel</code></pre>
</blockquote>
</body>
</html>