which bug?<br><br/><div style="font-size:12px;padding:2px 0;">---Original---</div><div style="font-size:12px;background:#f0f0f0;color:#212121;padding:8px!important;border-radius:4px;line-height:1.5;"><div><b>From:</b> "Jean-Baptiste Kempf"<jb@videolan.org></div><div><b>Date:</b> 2017/1/18 16:41:47</div><div><b>To:</b> "vlc-devel"<vlc-devel@videolan.org>;</div><div><b>Subject:</b> Re: [vlc-devel] [PATCH 03/10] converter/tospdif: always parse dtsheader</div></div><br/>This requires a comment, explaining the reason, IMHO.<br/><br/>On Wed, 18 Jan 2017, at 09:20, Thomas Guillem wrote:<br/>> In order to send only the core part (from write_buffer_dts()).<br/>> ---<br/>>  modules/audio_filter/converter/tospdif.c | 19 ++++++++-----------<br/>>  1 file changed, 8 insertions(+), 11 deletions(-)<br/>> <br/>> diff --git a/modules/audio_filter/converter/tospdif.c<br/>> b/modules/audio_filter/converter/tospdif.c<br/>> index f8a8a25f2b..bcc1f7c4a0 100644<br/>> --- a/modules/audio_filter/converter/tospdif.c<br/>> +++ b/modules/audio_filter/converter/tospdif.c<br/>> @@ -355,17 +355,14 @@ static int write_buffer_truehd( filter_t *p_filter,<br/>> block_t *p_in_buf )<br/>>  static int write_buffer_dts( filter_t *p_filter, block_t *p_in_buf )<br/>>  {<br/>>      uint16_t i_data_type;<br/>> -    if( p_in_buf->i_nb_samples == 0 )<br/>> -    {<br/>> -        /* Input is not correctly packetizer. Try to parse the buffer in<br/>> order<br/>> -         * to get the mandatory informations to play DTS over S/PDIF */<br/>> -        vlc_dts_header_t header;<br/>> -        if( vlc_dts_header_Parse( &header, p_in_buf->p_buffer,<br/>> -                                  p_in_buf->i_buffer ) != VLC_SUCCESS )<br/>> -            return SPDIF_ERROR;<br/>> -        p_in_buf->i_nb_samples = header.i_frame_length;<br/>> -        p_in_buf->i_buffer = header.i_frame_size;<br/>> -    }<br/>> +<br/>> +    vlc_dts_header_t header;<br/>> +    if( vlc_dts_header_Parse( &header, p_in_buf->p_buffer,<br/>> +                              p_in_buf->i_buffer ) != VLC_SUCCESS )<br/>> +        return SPDIF_ERROR;<br/>> +    p_in_buf->i_nb_samples = header.i_frame_length;<br/>> +    p_in_buf->i_buffer = header.i_frame_size;<br/>> +<br/>>      switch( p_in_buf->i_nb_samples )<br/>>      {<br/>>      case  512:<br/>> -- <br/>> 2.11.0<br/>> <br/>> _______________________________________________<br/>> vlc-devel mailing list<br/>> To unsubscribe or modify your subscription options:<br/>> https://mailman.videolan.org/listinfo/vlc-devel<br/><br/><br/>-- <br/>Jean-Baptiste Kempf -  President<br/>+33 672 704 734<br/>_______________________________________________<br/>vlc-devel mailing list<br/>To unsubscribe or modify your subscription options:<br/>https://mailman.videolan.org/listinfo/vlc-devel