<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta http-equiv="Content-Style-Type" content="text/css" />
<meta name="generator" content="pandoc" />
<title></title>
<style type="text/css">code{white-space: pre;}</style>
</head>
<body>
<p>Hi Hugo (and myself),</p>
<p>On 2017-01-23 15:58, Filip Roséen wrote:</p>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> + goto error;
+ }
+ }
+
+ p_sys->psz_additional_files = psz_data;</code></pre>
</blockquote>
</blockquote>
<pre><code> `(A)`: the above should be `psz_files`, and not `psz_data`.. though it
is important to note that `private_sys_t::psz_additional_files` is not
used anymore, and as such everything regarding that variable should be
removed.</code></pre>
</blockquote>
<p>What I wrote above is incorrect, I forgot that the data that <code>psz_additional_flags</code> refers to is indirectly used by other entities in the implementation.</p>
<p>Given that I wrote the implementation, and now became confused a few months after I originally wrote it – I reckon a clean-up is in order.</p>
<p>Once again, thanks for the review and for making me confused (hilighting the flaws in the implementation).</p>
</body>
</html>