<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta http-equiv="Content-Style-Type" content="text/css" />
<meta name="generator" content="pandoc" />
<title></title>
<style type="text/css">code{white-space: pre;}</style>
</head>
<body>
<p>Hi Rémi and Francois,</p>
<p>On 2017-02-20 18:30, Rémi Denis-Courmont wrote:</p>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> Le maanantaina 20. helmikuuta 2017, 14.23.53 EET Francois Cartegnie a écrit :</code></pre>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> allows using a non ffmpeg HEAD reference</code></pre>
</blockquote>
<pre><code> I have no clue what that is supposed to mean.</code></pre>
</blockquote>
<p>My guess is that Francois would like to be able to specify <code>FFMPEG_HASH=</code> as (example) <em>“refs/heads/release/12”</em> without running into issues because of the slashes (and potential dots).</p>
<p>I would however propose renaming <code>FFMPEG_HASH</code> to <code>FFMPEG_HEAD</code>, as the latter is a more accurate name given the accepted contents.</p>
<p>Currently <code>FFMPEG_HASH</code> of course accepts any <em>hash</em> (including <em>“HEAD”</em>) since such does not include the previously mentioned characters.</p>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> Surely the current code handles references other than "HEAD".</code></pre>
</blockquote>
<p>There is however a problem with the patch, and given that I just noticed that it got pushed I will reply to the relevant commit instead of outlining it here.</p>
<p>Not tested as I am on a very slow connection and don’t feel like emulating the retrieval, but <code>contrib/src/ffmpeg/rules.mak:219</code> (post patch) uses <code>FFMPEG_HASH</code> instead of <code>FFMPEG_BASENAME</code>.</p>
<p>Best Regards,<br />
Filip Roséen</p>
</body>
</html>