<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml"><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta http-equiv="Content-Style-Type" content="text/css" />
<meta name="generator" content="pandoc" />
<title></title>
<style type="text/css">code{white-space: pre;}</style>
</head><body><div class="gmail_quote">On February 20, 2017 7:14:04 PM GMT+02:00, "Filip Roséen" <filip@atch.se> wrote:<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<p>Hi Rémi,</p>
<p>On 2017-02-20 18:32, Rémi Denis-Courmont wrote:</p>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> Le maanantaina 20. helmikuuta 2017, 14.53.50 EET Filip Roséen a écrit :</code></pre>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> Following the changes in 7ecd927 the changed line caused a warning
related to signed vs unsigned integer comparision; this simply silence
that warning by using the now relevant type.</code></pre>
</blockquote>
<pre><code> Well yes but I left it because this code should use init/clear instead of new/
destroy (and I have not yet fixed that occurrence).</code></pre>
</blockquote>
<p>Understood, I just wanted to get rid of the current warnings as they hurt my eyes. Unless you plan on fixing the migration from <code>vlc_array_new</code> to <code>vlc_array_init</code> and <code>vlc_array_clear</code> tonight I’d be happy to do it.</p>
<p>While we are speaking about the matter, do you think it would make sense to introduce a <em><code>vlc_array_t</code>-initializer</em> that could be used as the below (not sure about the name though).</p>
<pre><code>vlc_array_t foo = VLC_ARRAY_INIT;</code></pre>
<p>instead of having:</p>
<pre><code>vlc_array_t foo;
vlc_array_init( &foo );</code></pre>
<p>Best Regards,<br />
Filip Roséen</p>
</blockquote></div><br clear="all">Help yourself then.<br>
<br>
I have no opinion on the initializer. It is only "necessary" for global or static scenarii, which I think we do not have. (And even then, the default initialization would actually work, if not pretty.)<br>
-- <br>
Rémi Denis-Courmont</body></html>