<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta http-equiv="Content-Style-Type" content="text/css" />
<meta name="generator" content="pandoc" />
<title></title>
<style type="text/css">code{white-space: pre;}</style>
</head>
<body>
<p>Hi Rémi,</p>
<p>On 2017-02-26 21:27, Rémi Denis-Courmont wrote:</p>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> As has been noted many times over, the VLC headers CANNOT depend on configure
output (since they are installed by the plugin SDK).
That is why all public headers use compiler/version checks.
So obvious nack.</code></pre>
</blockquote>
<p>What do you propose as an alternative? I am not too keen on supplying <code>-Wno-unknown-attributes</code> for the relevant compilers, and sprinkling things like <code>!defined( clang )</code> everywhere seems rather unpleasent.</p>
<p>Of course, the relevant (proposed) functionality could be implemented in the public headers with the compiler/version checks in place;</p>
<ul>
<li>would that be a suitable alternative?</li>
</ul>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> And with that said, if your compiler defines __GNUC__, it has to support GCC
extensions. That´s kind of the whole point. So looks like your compiler is
buggy.</code></pre>
</blockquote>
<p><code>clang</code> supports the relevant attributes starting with <code>5.0</code>, compiling VLC with <code>3.9.0</code> reproduces the described situation.</p>
<p>The same, of course, applies to the <em>buildbots</em> where one can see the described behavior in logs such as the ones below:</p>
<ul>
<li>https://jenkins.videolan.org/job/vlc-nightly/job/vlc-nightly-macOS/211/consoleText</li>
<li>https://jenkins.videolan.org/job/vlc-android/job/android-bin-x86/1011/consoleText</li>
</ul>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> --
雷米‧德尼-库尔蒙
https://www.remlab.net/
_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
https://mailman.videolan.org/listinfo/vlc-devel</code></pre>
</blockquote>
</body>
</html>