<!DOCTYPE html>
<html>
<head>
<title></title>
</head>
<body><div style="font-family:helvetica, arial, sans-serif;">Hello,<br></div>
<div><br></div>
<div>On Sun, 26 Feb 2017, at 23:32, Filip Roséen wrote:<br></div>
<blockquote type="cite"><p>Use the information available from <i>configure</i> <b>if</b> available (i.e. when we are building VLC), otherwise fall back to a more easily maintainable list of macros where we do not care about the exact compiler being used. Instead we would maintain in a way that corresponds to the current implementation. <code style="white-space: pre;">#ifdef __GNUC__</code> would unconditionally define the macros to what the <i>“compiler of our dream”</i> would implement.<br></p></blockquote><div style="font-family:helvetica, arial, sans-serif;"><br></div>
<div style="font-family:helvetica, arial, sans-serif;">If I remember correctly, the issue with that, beside vlc_fixups, that is done for this, it is not a great idea to have headers that depend on output of configure and of config.h. (notably for out-of-tree module building compilation, but there were other cases).<br></div>
<div style="font-family:helvetica, arial, sans-serif;"><br></div>
<div style="font-family:helvetica, arial, sans-serif;">I am quite sure this still exists in vlc_codecs.h, (the very badly named header), where we must have PACKED, but that should be the only other one where this exists.<br></div>
<div style="font-family:helvetica, arial, sans-serif;"><br></div>
<div style="font-family:helvetica, arial, sans-serif;">I remember that we had this discussion too, because we use the non-standard #warning and #error.<br></div>
<div style="font-family:helvetica, arial, sans-serif;"><br></div>
<div style="font-family:helvetica, arial, sans-serif;">But I totally agree on the fact that ifderies depending on compiler names and versions are really not cool too.<br></div>
<div style="font-family:helvetica, arial, sans-serif;">Especially since we have way too many GCC-isms and GNU-isms.<br></div>
<div style="font-family:helvetica, arial, sans-serif;">And this is totally relevant since GCC is soon going to be our compiler only for most distributions of Linux. All the other ones will be using llvm/clang: indeed, even the Mingw migration to llvm is ongoing.<br></div>
<div style="font-family:helvetica, arial, sans-serif;"><br></div>
<div style="font-family:helvetica, arial, sans-serif;">BR,<br></div>
<div id="sig60240713"><div class="signature">--<br></div>
<div class="signature">Jean-Baptiste Kempf - President<br></div>
<div class="signature">+33 672 704 734<br></div>
<div class="signature"> <br></div>
<div class="signature"><br></div>
</div>
<div style="font-family:helvetica, arial, sans-serif;"><br></div>
</body>
</html>