<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta http-equiv="Content-Style-Type" content="text/css" />
<meta name="generator" content="pandoc" />
<title></title>
<style type="text/css">code{white-space: pre;}</style>
</head>
<body>
<p>Hi Jean-Baptiste,</p>
<p>On 2017-02-27 03:52, Jean-Baptiste Kempf wrote:</p>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> On Sun, 26 Feb 2017, at 23:32, Filip Roséen wrote:</code></pre>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> Use the information available from *configure* *if* available (i.e.
when we are building VLC), otherwise fall back to a more easily
maintainable list of macros where we do not care about the exact
compiler being used. Instead we would maintain in a way that
corresponds to the current implementation. #ifdef __GNUC__ would
unconditionally define the macros to what the *“compiler of our
dream”* would implement.</code></pre>
</blockquote>
<pre><code> If I remember correctly, the issue with that, beside vlc_fixups, that is
done for this, it is not a great idea to have headers that depend on
output of configure and of config.h. (notably for out-of-tree module
building compilation, but there were other cases).</code></pre>
</blockquote>
<p>For <em>out-of-tree</em> compilation it would still work as this approach no longer has a mandatory dependency on the <em>configure</em> result, but an optional one; or are you saying that even with the approach taken in the <a href="https://github.com/FilipRoseen-refp/vlc/commits/0000_attributes">linked branch</a>, with the <a href="https://github.com/FilipRoseen-refp/vlc/commit/68ad551238b0b70de1c48bd977ac37dfe5de5f28">relevant commit</a> we will suffer?</p>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> I am quite sure this still exists in vlc_codecs.h, (the very badly named
header), where we must have PACKED, but that should be the only other
one where this exists.
I remember that we had this discussion too, because we use the non-
standard #warning and #error.</code></pre>
</blockquote>
<p>I was sadly not part of said discussion. If it is possible, could you link me to the <em>mailing-thread/threads</em> so that I can read what was stated there?</p>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> But I totally agree on the fact that ifderies depending on compiler
names and versions are really not cool too.
Especially since we have way too many GCC-isms and GNU-isms.
And this is totally relevant since GCC is soon going to be our compiler
only for most distributions of Linux. All the other ones will be using
llvm/clang: indeed, even the Mingw migration to llvm is ongoing.</code></pre>
</blockquote>
<p>Best Regards,<br />
Filip Roséen</p>
</body>
</html>