<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta http-equiv="Content-Style-Type" content="text/css" />
<meta name="generator" content="pandoc" />
<title></title>
<style type="text/css">code{white-space: pre;}</style>
</head>
<body>
<p>Hi <code>vlc-devel</code>,</p>
<p>On 2017-03-01 09:52, Filip Roséen wrote:</p>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> diff --git a/src/input/control.c b/src/input/control.c
index f4781eb1a5..ff6df4c2fe 100644
--- a/src/input/control.c
+++ b/src/input/control.c
@@ -399,7 +399,7 @@ int input_vaControl( input_thread_t *p_input, int i_query, va_list args )
return VLC_EGENERIC;
}
- input_title_t *p_title = vlc_input_title_Duplicate( priv->title[*pi_title_to_fetch] );
+ input_title_t *p_title = priv->title[*pi_title_to_fetch];</code></pre>
</blockquote>
<p>I just noticed that this patch results in a warning due to <code>input_thread_private_t::title</code> being <em>const-qualified</em>, and <code>p_title</code> lacking such qualifier.</p>
<p>See attached patch for a fixup of <a href="http://git.videolan.org/?p=vlc.git;a=commit;h=d1feba6e5f90e48e41cc507ab574f3a1091047f5"><code>d1feba6</code></a>.</p>
<p>Best Regards,<br />
Filip</p>
</body>
</html>