<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta http-equiv="Content-Style-Type" content="text/css" />
<meta name="generator" content="pandoc" />
<title></title>
<style type="text/css">code{white-space: pre;}</style>
</head>
<body>
<p>Erhm, I have no idea why my brain decided to sprinkle <em>“not”</em> in places where it certainly does not belong.</p>
<p>Sorry about the confusion (if any).</p>
<p>Best Regards,<br />
Filip Roséen</p>
<p>On 2017-03-11 21:34, Filip Roséen wrote:</p>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> The above check of `*psz_val` is redundant as `atoi` will return `0`
on an empty (or ill-formed) string.</code></pre>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> + else if( !strcasecmp( "style", psz_attr ) && psz_val && *psz_val )
+ if( !strcasecmp( "italic", psz_val ) )
+ b_italic = true;</code></pre>
</blockquote>
<pre><code> Same thing about `*psz_val` in the above, `strcasecmp` will not return
`0` for an empty string.</code></pre>
</blockquote>
<p>Should be read as <em>“<code>strcasecmp</code> <strong>will</strong> return <code>0</code> for an empty string”</em>.</p>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> + }
+
+ if( i_weight == 700 )
+ b_bold = true;</code></pre>
</blockquote>
<pre><code> As a font can be either *bold* or *not-bold* through `NewFont`, it
might make sense to check whether `i_weight` is
*greater-than-or-equal* to 700 (as `701` would not result in a
*non-bold* font).</code></pre>
</blockquote>
<p>Last part should be read as <em>“as <code>701</code> <strong>would</strong> result in a <em>non-bold</em> font”</em>.</p>
</body>
</html>