<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta http-equiv="Content-Style-Type" content="text/css" />
<meta name="generator" content="pandoc" />
<title></title>
<style type="text/css">code{white-space: pre;}</style>
</head>
<body>
<p>Hi Rémi,</p>
<p>On 2017-03-15 14:49, Rémi Denis-Courmont wrote:</p>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> On March 15, 2017 11:07:57 AM GMT+02:00, "Filip Roséen" <filip@atch.se> wrote:</code></pre>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code>Given that vlc_assert_unreachable relies on assert from <assert.h>,
this header should be included in order to simplify usage of the
macro.</code></pre>
</blockquote>
<pre><code> I disagree. It is bad practice to include headers in headers, as it
makes for sloppy code and harder revectoring. Especially when you
don't need it. BSD style is even more extreme: you have to include
necessary headers before dependent headers. So this situation is not
really exceptional.
That is also the point in using a macro rather than an a static
inline.</code></pre>
</blockquote>
<p>Noted.</p>
<p>I do not care too much about this particular issue, but I noticed translation-units that makes use <code>vlc_assert_unreachable</code>, while relying on <em>indirect</em> includes of <code><assert.h></code>.</p>
<p>With your message in mind I will submit a patch-batch with fixes for these cases instead of touching <code>vlc_common.h</code>.</p>
<p>Best Regards,<br />
Filip Roséen</p>
</body>
</html>