<!DOCTYPE html>
<html>
<head>
<title></title>
</head>
<body><div>There is one big issue that is also present with the aout drain.<br></div>
<div><br></div>
<div>Drains are synchronous, the decoder can't process any commands during the draining (like pause or quit).<br></div>
<div>If there is 1 seconds of picture to drain, the decoder (hence the input, hence the UI) won't be able to stop for 1 seconds if the user requested it.<br></div>
<div><br></div>
<div>We could do an asynchronous drain for the vout, with more cond/lock complexity in decoder.c.<br></div>
<div>But for the aout, it will be more complicated, we'll have to modify the drain implementation of all our modules.<br></div>
<div><br></div>
<div>On Wed, Mar 15, 2017, at 15:49, Filip Roséen wrote:<br></div>
<blockquote type="cite"><p>Hi Rémi (and Thomas),<br></p><p>On 2017-03-15 16:44, Rémi Denis-Courmont wrote:<br></p><blockquote style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204, 204, 204);padding-left:1ex;color:rgb(80, 0, 80);"><pre><code style="white-space: pre;"> On March 15, 2017 4:33:30 PM GMT+02:00, Thomas Guillem <thomas@gllm.fr> wrote:</code><br></pre><blockquote style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204, 204, 204);padding-left:1ex;color:rgb(80, 0, 80);"><pre><code style="white-space: pre;">vout_Drain() asks the vout thread to drain its queued pictures. This
function
will wait for the last picture to be displayed.
Refs #18105</code><br></pre></blockquote><pre><code style="white-space: pre;"> Fine With me but I fear this sort of thing is not to the liking of the ES output buffering code.</code><br></pre></blockquote><p>The ES buffering code does <b>sadly</b> not care about neither decoder nor {audio,video}-output, so this patch should not affect anything in terms of buffering from the <i>es-out</i>’s point of view.<br></p><div><u>_______________________________________________</u><br></div>
<div>vlc-devel mailing list<br></div>
<div>To unsubscribe or modify your subscription options:<br></div>
<div><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div>
</blockquote><div><br></div>
</body>
</html>