<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta http-equiv="Content-Style-Type" content="text/css" />
<meta name="generator" content="pandoc" />
<title></title>
<style type="text/css">code{white-space: pre;}</style>
</head>
<body>
<p>Hi Rémi,</p>
<p>On 2017-03-15 16:06, Rémi Denis-Courmont wrote:</p>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> Personally, I develop mainly on a build with --enable-debug and without
any other options. When I want to use a sanitizer, a use an other dir
with different configure rules.</code></pre>
</blockquote>
<pre><code> If you really want to make sanitizers easy to use, then add an option to
enable them, like we do for coverage. Not this patch, please.</code></pre>
</blockquote>
<p>I wrote this patch for several reasons, not only related to sanitizers (maybe I should have expanded that section in the patch note though).</p>
<p>Indeed, and I was toying with the idea of implementing functionality so that <code>--enable-sanitizer={address,undefined,thread}</code> would work correctly. During those minutes spent thinking about it, it became clear quite fast that just having it work on the combinations of platform+compiler of just the people that frequent <code>#videolan</code> would be quite a pain.</p>
<p>For things to be towards the easier side of implementation, as well as with faster build/execution speed, <code>-Wl,-z,defs</code> and <code>-no-undefined</code> should be disabled through usage such as <code>--enable-sanitizer=address</code>.</p>
<p>However, if it is acceptable for <code>--enable-sanitizer=address</code> to circumvent that check, I am not sure why a developer should not be able to manually specify that he/she would not like the check for undefined references.</p>
<p>A developer should know his/her platform well enough to be able to manually specify the sanitizer flags, which <code>--disable-no-undefined</code> allows.</p>
<p>I did not see a future <code>--enable-sanitizer={...}</code> flag and <code>--{enable,disable}-no-undefined</code> to be mutually exclusive.</p>
<p>Best Regards,<br />
Filip</p>
</body>
</html>