<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta http-equiv="Content-Style-Type" content="text/css" />
<meta name="generator" content="pandoc" />
<title></title>
<style type="text/css">code{white-space: pre;}</style>
</head>
<body>
<p>Hi Hugo,</p>
<p>On 2017-03-17 10:54, Hugo Beauzée-Luyssen wrote:</p>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> On Fri, Mar 17, 2017, at 03:22 AM, Filip Roséen wrote:</code></pre>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> ---
modules/stream_extractor/archive.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)</code></pre>
</blockquote>
</blockquote>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> + if( archive_init( p_sys, p_extractor->source ) ||
+ archive_seek_subentry( p_sys, p_extractor->identifier )
)
+ {
+ msg_Err( p_extractor,
+ "fatal: unable to recreate libarchive handle" );
+ p_sys->b_dead = false;</code></pre>
</blockquote>
<pre><code> Don't you mean true?</code></pre>
</blockquote>
<p>I actually meant to not have that assignment to <code>p_sys->b_dead</code> at all, seems like I did the rebasing a little fast and ended up with a <code>fixup</code> where it should have been a <code>drop</code>.</p>
<p>I also just noticed that there is one patch missing from this set. See attached patch for an updated one, and expect another one being sent to <code>vlc-devel</code> really soon.</p>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> return VLC_EGENERIC;
+ }
i_skip = i_req;
i_offset = 0;</code></pre>
</blockquote>
<pre><code> And assuming you meant `true` doesn't this make patch 4 obsolete? As far
as I understand the only way of having a NULL p_entry is to have a
successful archive_clean call followed by a failing archive_init call,
however you </code></pre>
</blockquote>
<p>Seems your message got truncated, but see earlier paragraph.</p>
<p>Thanks for the review, and happy friday!</p>
<p>Best Regards,<br />
Filip Roséen</p>
</body>
</html>