<!DOCTYPE html>
<html>
<head>
<title></title>
</head>
<body><div style="font-family:helvetica, arial, sans-serif;">Hello Lukas,<br></div>
<div style="font-family:helvetica, arial, sans-serif;"><br></div>
<div style="font-family:helvetica, arial, sans-serif;">Thanks a lot for this patch.<br></div>
<div style="font-family:helvetica, arial, sans-serif;"><br></div>
<div style="font-family:helvetica, arial, sans-serif;">But don't you break NowPlaying with this? Or cases where the codec has different metadata from the demux?<br></div>
<div><br></div>
<div style="font-family:helvetica, arial, sans-serif;">Best,<br></div>
<div><br></div>
<div>On Wed, 22 Mar 2017, at 00:38, Lukas Solanka wrote:<br></div>
<blockquote type="cite"><div dir="ltr"><div style="font-size:small;">Fixes the track title issue described in #4143, but does not deal with track duration.<br></div>
</div>
<div><div style="font-family:helvetica, arial, sans-serif;"><br></div>
<div defang_data-gmailquote="yes"><div style="font-family:helvetica, arial, sans-serif;">On 21 March 2017 at 23:21, Lukas Solanka <span dir="ltr"><<a href="mailto:lsolanka@gmail.com">lsolanka@gmail.com</a>></span> wrote:<br></div>
<blockquote defang_data-gmailquote="yes" style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204, 204, 204);padding-left:1ex;"><div style="font-family:helvetica, arial, sans-serif;">This applies mostly to cue+single file flac situations when the flac file does<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> not have appropriate metadata. In those cases the track title coming from the<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> cue file is overwritten by the title from the flac file (usually album name and<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> not track name). This patch prevents that and keeps to original metadata, but<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> allows to insert new fields if necessary.<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> ---<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> src/input/meta.c | 3 ++-<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> 1 file changed, 2 insertions(+), 1 deletion(-)<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> <br></div>
<div style="font-family:helvetica, arial, sans-serif;"> diff --git a/src/input/meta.c b/src/input/meta.c<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> index 9b79d42..8bf0baf 100644<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> --- a/src/input/meta.c<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> +++ b/src/input/meta.c<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> @@ -181,7 +181,8 @@ void vlc_meta_Merge( vlc_meta_t *dst, const vlc_meta_t *src )<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> <br></div>
<div style="font-family:helvetica, arial, sans-serif;"> for( int i = 0; i < VLC_META_TYPE_COUNT; i++ )<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> {<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> - if( src->ppsz_meta[i] )<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> + /* Merge only meta not inserted before by someone else */<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> + if( !dst->ppsz_meta[i] && src->ppsz_meta[i] )<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> {<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> free( dst->ppsz_meta[i] );<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> dst->ppsz_meta[i] = strdup( src->ppsz_meta[i] );<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> <span><span class="colour" style="color:rgb(136, 136, 136)">--<br> 2.5.0<br> </span></span></div>
</blockquote></div>
</div>
<div><u>_______________________________________________</u><br></div>
<div>vlc-devel mailing list<br></div>
<div>To unsubscribe or modify your subscription options:<br></div>
<div><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div>
</blockquote><div style="font-family:helvetica, arial, sans-serif;"><br></div>
<div id="sig60240713"><div class="signature">--<br></div>
<div class="signature">Jean-Baptiste Kempf - President<br></div>
<div class="signature">+33 672 704 734<br></div>
<div class="signature"> <br></div>
<div class="signature"><br></div>
</div>
<div style="font-family:helvetica, arial, sans-serif;"><br></div>
</body>
</html>