<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta http-equiv="Content-Style-Type" content="text/css" />
<meta name="generator" content="pandoc" />
<title></title>
<style type="text/css">code{white-space: pre;}</style>
</head>
<body>
<p>Hi Francois,</p>
<p>On 2017-03-22 15:13, Francois Cartegnie wrote:</p>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> Le 22/03/2017 à 14:32, Filip Roséen a écrit :</code></pre>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> + if( p_pic->i_length == 0 )
+ {
+ if( p_sps->vui.i_time_scale )
+ {
+ p_pic->i_length = CLOCK_FREQ * i_num_clock_ts *
+ p_sps->vui.i_num_units_in_tick / p_sps->vui.i_time_scale;</code></pre>
</blockquote>
<pre><code> I cannot see how the above is valid if `p_sps->vui.b_fixed_frame_rate
== 0`, as such I propose the attached patch as a fixup. I would
however be happy to stand corrected as learning something new is
always welcomed.</code></pre>
</blockquote>
<pre><code> b_fixed_frame_rate and time_scale presences are not exclusive.</code></pre>
</blockquote>
<p>I was aware of that, and I guess the relevant calculation is equivalent of querying the maximum possible-frame rate (ie. the minimal duration the p_pic will have) in that case - would that be correct?</p>
<p>Thanks for your answer, the more knowledge gained - the better!</p>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> i_num_clock_ts is timing and is valid, fixed rate or not.
The only issue here is time_scale not matching demuxer's values/dts.</code></pre>
</blockquote>
<p>As my curiousity is pretty much always present, please feel free to only reply to questions such as this when you have time to spare (that of course applies to others reading this thread as well).</p>
<p>There is absolutely no rush.</p>
<p>Best Regards,<br />
Filip</p>
</body>
</html>