<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi<br>
<br>
I was advised to send the patch again on IRC because I had some
issues with the list.<br>
<br>
This is the only issue, that prevents me from building VLC on Arch
Linux with Lua 5.3 (x64). See also the patch in the AUR package [1].<br>
In 2468da50f6048be1d4a4ae188fa579f4fe741b40 <span
class="blob-code-inner"><span class="pl-en">most luaL_checkint()
have already been replaced and also LUA_COMPAT_APIINTCASTS have
been removed. 520b13a2ca88fc63ba3c1287e9314fbb2777c85d revert
parts of this, without adding LUA_COMPAT_APIINTCASTS again and
without a clear reason in the commit message.<br>
<br>
</span></span>Do you have any test infrastructure for those
architectures/platforms that might have trouble with this patch? I
would be interested to have a look at those issues.<br>
Referring to the Lua docs it seems to be a drop-in replacement.<br>
<br>
Regards,<br>
Jonas<br>
<br>
[1]
<a class="moz-txt-link-freetext" href="https://aur.archlinux.org/cgit/aur.git/tree/lua53_compat.patch?h=vlc-git">https://aur.archlinux.org/cgit/aur.git/tree/lua53_compat.patch?h=vlc-git</a><br>
<br>
<br>
<br>
<div class="moz-cite-prefix">Am 30.03.2017 um 09:47 schrieb Luca
Barbato:<br>
</div>
<blockquote
cite="mid:d802249c-24dc-25e9-b663-5314ed0d4723@gentoo.org"
type="cite">
<pre wrap="">On 26/03/2017 23:00, sjw wrote:
</pre>
<blockquote type="cite">
<pre wrap="">This reverts commit 520b13a2ca88fc63ba3c1287e9314fbb2777c85d,
because it breaks builds with Lua 5.3.
'luaL_checkint()' is deprecated since Lua 5.3
</pre>
</blockquote>
<pre wrap="">
Hi, from what I can see from the ml exchange in August Lua 5.3 is not
really supported and the code is the way it is for a good reason (that
cast might result in surprising values on certain architectures/platforms).
It is the second time you are sending this patch, could you please stop?
lu
_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
<a class="moz-txt-link-freetext" href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre>
</blockquote>
<br>
</body>
</html>