<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta http-equiv="Content-Style-Type" content="text/css" />
<meta name="generator" content="pandoc" />
<title></title>
<style type="text/css">code{white-space: pre;}</style>
</head>
<body>
<p>Hi Steve,</p>
<p>On 2017-04-03 09:47, Steve Lhomme wrote:</p>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> On Sun, Apr 2, 2017 at 11:24 PM, Filip Roséen <filip@atch.se> wrote:</code></pre>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> On 2017-03-31 18:14, Steve Lhomme wrote:
---
include/vlc_variables.h | 4 ++--
modules/access/decklink.cpp | 2 +-
modules/access/imem.c | 4 ++--
modules/access/timecode.c | 3 +--
modules/access/v4l2/video.c | 9 ++++-----
modules/demux/image.c | 4 ++--
modules/demux/rawvid.c | 5 ++---
modules/stream_out/transcode/transcode.c | 2 +-
modules/video_filter/fps.c | 2 +-
src/misc/variables.c | 16 ++++++++--------
src/video_output/video_output.c | 3 +--
test/src/misc/variables.c | 32
++++++++++++++++----------------
12 files changed, 41 insertions(+), 45 deletions(-)
diff --git a/include/vlc_variables.h b/include/vlc_variables.h
index 83752b171f..59ad99367c 100644
--- a/include/vlc_variables.h
+++ b/include/vlc_variables.h
@@ -652,8 +652,8 @@ static inline void *var_InheritAddress( vlc_object_t
*obj, const char *name )
}
#define var_InheritAddress(o, n) var_InheritAddress(VLC_OBJECT(o), n)
-VLC_API int var_InheritURational( vlc_object_t *, unsigned *num, unsigned
*den, const char *var );
-#define var_InheritURational(a,b,c,d) var_InheritURational(VLC_OBJECT(a),
b, c, d)
+VLC_API int var_InheritURational( vlc_object_t *, vlc_rational_t *dst,
const char *var );
+#define var_InheritURational(a,b,d) var_InheritURational(VLC_OBJECT(a), b,
d)
#define var_GetInteger(a,b) var_GetInteger( VLC_OBJECT(a),b)
#define var_GetBool(a,b) var_GetBool( VLC_OBJECT(a),b)
diff --git a/modules/access/decklink.cpp b/modules/access/decklink.cpp
index c4c043559b..248009ed15 100644
--- a/modules/access/decklink.cpp
+++ b/modules/access/decklink.cpp
@@ -197,7 +197,7 @@ static es_format_t GetModeSettings(demux_t *demux,
IDeckLinkDisplayMode *m)
video_fmt.i_bitrate = video_fmt.video.i_width *
video_fmt.video.i_height * video_fmt.video.i_frame_rate * 2 * 8;
vlc_rational_t aspect;
- if (!var_InheritURational(demux, &aspect.num, &aspect.den,
"decklink-aspect-ratio") &&
+ if (!var_InheritURational(demux, &aspect, "decklink-aspect-ratio") &&
aspect_num > 0 && aspect_den > 0) {
The above leaves usage of aspect_num and aspect_den, even though these are
no longer written to by var_InheritURational - which cannot be correct.</code></pre>
</blockquote>
<pre><code> ??? These variables went away in the previous patch.</code></pre>
</blockquote>
<p>Then how come they are still present in the above diff? I am not sure if those “???” are directed to me or something else, though.</p>
<p>As already stated, I have not applied your patches locally nor tried to compile them - but the diff certainly states that <code>aspect_num > 0</code> and <code>aspect_den > 0</code> are still there.</p>
<p>Best Regards,<br />
Filip</p>
</body>
</html>