<html><head></head><body><div class="gmail_quote">Le 23 juin 2017 17:30:09 GMT+03:00, Martin Briza <mbriza@redhat.com> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">Wayland users now have no choice (except setting WAYLAND_DISPLAY to '') how to avoid getting VLC under Wayland which may not be optimal yet.<br /><br />This patch ensures the XCB backend is preferred. This means the developers who want to work on Wayland support will have to clear their DISPLAY variable instead.<br /><br />Related to <a href="https://trac.videolan.org/vlc/ticket/18383">https://trac.videolan.org/vlc/ticket/18383</a> .<br />---<br /> modules/gui/qt/qt.cpp | 10 +++++-----<br /> 1 file changed, 5 insertions(+), 5 deletions(-)<br /><br />diff --git a/modules/gui/qt/qt.cpp b/modules/gui/qt/qt.cpp<br />index 2ad68eb..3224361 100644<br />--- a/modules/gui/qt/qt.cpp<br />+++ b/modules/gui/qt/qt.cpp<br />@@ -411,16 +411,16 @@ static int Open( vlc_object_t *p_this, bool isDialogProvider )<br /> intf_thread_t *p_intf = (intf_thread_t *)p_this;<br /> void *(*thread)(void *) = Thread;<br /> <br />-#ifdef QT5_HAS_WAYLAND<br />- if( HasWayland() )<br />- thread = ThreadWayland;<br />- else<br />-#endif<br /> #ifdef QT5_HAS_X11<br /> if( HasX11( p_this ) )<br /> thread = ThreadXCB;<br /> else<br /> #endif<br />+#ifdef QT5_HAS_WAYLAND<br />+ if( HasWayland() )<br />+ thread = ThreadWayland;<br />+ else<br />+#endif<br /> #if defined (QT5_HAS_X11) || defined (QT5_HAS_WAYLAND)<br /> return VLC_EGENERIC;<br /> #endif</pre></blockquote></div><br clear="all">I don't see any rationale why Xlib should have priority over Wayland. Normally, if you have both, you want the later.<br>
<br>
The referenced bug alleges Qt bugs in the version of Qt shipped by Fedora. That's not a rationale in the context of this upstream VLC repository.<br>
-- <br>
Rémi Denis-Courmont<br>
Typed on an inconvenient virtual keyboard</body></html>