<!DOCTYPE html>
<html>
<head>
<title></title>
</head>
<body><div style="font-family:helvetica, arial, sans-serif;">Hello,<br></div>
<div><br></div>
<div>On Fri, 7 Jul 2017, at 17:23, Rémi Denis-Courmont wrote:<br></div>
<blockquote type="cite"><div defang_data-gmailquote="yes"><div style="font-family:helvetica, arial, sans-serif;">- if (src->i_width == 0 || src->i_width > 8192 ||<br></div>
<blockquote defang_data-gmailquote="yes" style="margin-top:0pt;margin-right:0pt;margin-bottom:0pt;margin-left:0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204, 204, 204);padding-left:1ex;"><pre><div style="font-family:helvetica, arial, sans-serif;">- src->i_height == 0 || src->i_height > 8192)<br></div>
<div style="font-family:helvetica, arial, sans-serif;">+ if (src->i_width == 0 || src->i_width > 32768 ||<br></div>
<div style="font-family:helvetica, arial, sans-serif;">+ src->i_height == 0 || src->i_height > 32768)<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> return VLC_EGENERIC;<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> if (src->i_sar_num <= 0 || src->i_sar_den <= 0)<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> return VLC_EGENERIC;<br></div>
</pre></blockquote></div>
<div style="font-family:helvetica, arial, sans-serif;"><br></div>
<div style="font-family:helvetica, arial, sans-serif;">You most probably can't just do that. This will most probably lead to overflow in 32-bits arithmetic, and I can't see any attempt to address that in the patch series.<br></div>
</blockquote><div style="font-family:helvetica, arial, sans-serif;"><br></div>
<div style="font-family:helvetica, arial, sans-serif;">Are you speaking about the picture size?<br></div>
<div style="font-family:helvetica, arial, sans-serif;"><br></div>
<div style="font-family:helvetica, arial, sans-serif;">2^15*2^15*4 (planes) ?<br></div>
<div style="font-family:helvetica, arial, sans-serif;"><br></div>
<div style="font-family:helvetica, arial, sans-serif;">Would staying at 2^14 be better, for now?<br></div>
<div style="font-family:helvetica, arial, sans-serif;"><br></div>
<div style="font-family:helvetica, arial, sans-serif;"><br></div>
<div id="sig60240713"><div class="signature">--<br></div>
<div class="signature">Jean-Baptiste Kempf - President<br></div>
<div class="signature">+33 672 704 734<br></div>
<div class="signature"> <br></div>
<div class="signature"><br></div>
</div>
<div style="font-family:helvetica, arial, sans-serif;"><br></div>
</body>
</html>