<html><head></head><body><div class="gmail_quote">Le 8 juillet 2017 19:09:55 GMT+03:00, Steve Lhomme <robux4@gmail.com> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">On Sat, Jul 8, 2017 at 6:07 PM, Rémi Denis-Courmont <remi@remlab.net> wrote:<br /><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"> Le 8 juillet 2017 18:34:25 GMT+03:00, Steve Lhomme <robux4@gmail.com> a<br /> écrit :<br /><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;"><br /> On Fri, Jul 7, 2017 at 7:08 PM, Rémi Denis-Courmont <remi@remlab.net><br /> wrote:<br /><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;"><br /> Le keskiviikkona 5. heinäkuuta 2017, 17.00.23 EEST Steve Lhomme a écrit<br /> :<br /><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #fcaf3e; padding-left: 1ex;"><br /> ---<br /> modules/demux/adaptive/plumbing/FakeESOut.cpp | 2 +-<br /> modules/demux/adaptive/plumbing/FakeESOutID.cpp | 2 +-<br /> 2 files changed, 2 insertions(+), 2 deletions(-)<br /><br /> diff --git a/modules/demux/adaptive/plumbing/FakeESOut.cpp<br /> b/modules/demux/adaptive/plumbing/FakeESOut.cpp index<br /> 781f2c8b6f..591e602232 100644<br /> --- a/modules/demux/adaptive/plumbing/FakeESOut.cpp<br /> +++ b/modules/demux/adaptive/plumbing/FakeESOut.cpp<br /> @@ -91,7 +91,7 @@ void FakeESOut::setExtraInfoProvider(<br /> ExtraFMTInfoInterface *extra ) FakeESOutID * FakeESOut::createNewID(<br /> const<br /> es_format_t *p_fmt )<br /> {<br /> es_format_t fmtcopy;<br /> - es_format_Init( &fmtcopy, 0, 0 );<br /> + es_format_Init( &fmtcopy, p_fmt->i_cat, 0 );<br /> es_format_Copy( &fmtcopy, p_fmt );<br /> fmtcopy.i_group = 0; /* Always ignore group for adaptive */<br /> fmtcopy.i_id = -1;<br /> diff --git a/modules/demux/adaptive/plumbing/FakeESOutID.cpp<br /> b/modules/demux/adaptive/plumbing/FakeESOutID.cpp index<br /> 30b5eba19e..29ef239776 100644<br /> --- a/modules/demux/adaptive/plumbing/FakeESOutID.cpp<br /> +++ b/modules/demux/adaptive/plumbing/FakeESOutID.cpp<br /> @@ -32,7 +32,7 @@ FakeESOutID::FakeESOutID( FakeESOut *fakeesout, const<br /> es_format_t *p_fmt ) , p_real_es_id( NULL )<br /> , pending_delete( false )<br /> {<br /> - es_format_Init( &fmt, 0, 0 );<br /> + es_format_Init( &fmt, p_fmt->i_cat, 0 );<br /> es_format_Copy( &fmt, p_fmt );<br /> }<br /></blockquote><br /><br /> This was and remains pointless. es_format_Copy() discards the output<br /> content.<br /></blockquote><br /><br /> If types were strongly enforced, you couldn't pass 0 here, it should<br /> always be a category. Also a module should not change the ES category<br /> (it seems visualisation filters don't do that but I might be wrong).<br /> Once the ES is created it should not be changed.<br /><br /><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;"> --<br /> 雷米‧德尼-库尔蒙<br /> <a href="https://www.remlab.net">https://www.remlab.net</a>/<br /><br /><hr /><br /><br /> vlc-devel mailing list<br /> To unsubscribe or modify your subscription options:<br /> <a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br /></blockquote><br /><hr /><br /><br /> vlc-devel mailing list<br /> To unsubscribe or modify your subscription options:<br /> <a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br /></blockquote><br /><br /> Yes and ?<br /> --<br /> Rémi Denis-Courmont<br /> Typed on an inconvenient virtual keyboard<br /><br /><hr /><br /> vlc-devel mailing list<br /> To unsubscribe or modify your subscription options:<br /> <a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br /></blockquote><br />That's it, I explained why 0 is not a good value.<br /><hr /><br />vlc-devel mailing list<br />To unsubscribe or modify your subscription options:<br /><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre></blockquote></div><br clear="all">What does that have to do with my comment about the call being entirely useless ?<br>
-- <br>
Rémi Denis-Courmont<br>
Typed on an inconvenient virtual keyboard</body></html>