<div dir="ltr">Hi Francois,<span><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Jul 9, 2017 at 11:20 PM, Francois Cartegnie <span dir="ltr"><<a href="mailto:fcvlcdev@free.fr" target="_blank">fcvlcdev@free.fr</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;padding-left:1ex;border-left-color:rgb(204,204,204);border-left-width:1px;border-left-style:solid"><span>Le 07/07/2017 à 05:56, Zhao Zhili a écrit :<br>
> ---<br>
>  modules/demux/adaptive/<wbr>plumbing/FakeESOut.cpp | 1 +<br>
>  1 file changed, 1 insertion(+)<br>
><br>
> diff --git a/modules/demux/adaptive/<wbr>plumbing/FakeESOut.cpp<br>
> b/modules/demux/adaptive/<wbr>plumbing/FakeESOut.cpp<br>
> index 781f2c8..3ae04a4 100644<br>
> --- a/modules/demux/adaptive/<wbr>plumbing/FakeESOut.cpp<br>
> +++ b/modules/demux/adaptive/<wbr>plumbing/FakeESOut.cpp<br>
> @@ -378,6 +378,7 @@ int FakeESOut::esOutControl_<wbr>Callback(es_out_t *fakees,<br>
> int i_query, va_list args<br>
>              else<br>
>                  i_group = 0;<br>
>              int64_t  pcr = va_arg( args, int64_t );<br>
> +            me->checkTimestampsStart( pcr );<br>
>              pcr += me->getTimestampOffset();<br>
>              AbstractCommand *command =<br>
> me->commandsqueue->factory()-><wbr>createEsOutControlPCRCommand( i_group, pcr );<br>
>              if( likely(command) )<br>
<br>
</span>I don't know what you're trying to fix, but that implies a lot of tests.<br>
<br>
Since pcr in adaptive is only used for stream progress, that means you<br>
have an incorrect buffering level bug.<br>
<br></blockquote><div><br></div><div>Yes, I have an incorrect buffering level bug. es_out_Control() ES_OUT_SET_PCR can be </div><div>called before es_out_Send(), so the first PCR didn't plus timestamps_offset. Discontinuities</div><div>of PCR lead to incorrect buffering level, for example:</div><div><br></div><div>[00007effe80009e0] core input debug: Stream buffering done (526633 ms in 8058 ms)<span></span></div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;padding-left:1ex;border-left-color:rgb(204,204,204);border-left-width:1px;border-left-style:solid">
Francois<br>
______________________________<wbr>_________________<br>
vlc-devel mailing list<br>
To unsubscribe or modify your subscription options:<br>
<a href="https://mailman.videolan.org/listinfo/vlc-devel" target="_blank" rel="noreferrer">https://mailman.videolan.org/<wbr>listinfo/vlc-devel</a></blockquote></div><br></div></span></div>