<div dir="ltr"><div>Hi Jean-Baptiste，<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jul 10, 2017 at 1:39 AM, Jean-Baptiste Kempf <span dir="ltr"><<a href="mailto:jb@videolan.org" target="_blank">jb@videolan.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;padding-left:1ex;border-left-color:rgb(204,204,204);border-left-width:1px;border-left-style:solid"><u>




</u><div><div style="font-family:helvetica,arial,sans-serif">Why? <br></div>
<div style="font-family:helvetica,arial,sans-serif"><br></div>
<div style="font-family:helvetica,arial,sans-serif">I'm sorry, but this means a bit more justification, in the commit log, and probably in the code.<br></div><div><div class="gmail-h5">
<div><br></div></div></div></div></blockquote><div><br></div><div>1. Set  kCVPixelBufferBytesPerRowAlign<wbr>mentKey to 16 makes memory usage smaller on iOS devices.</div><div>2. I didn't find any side effect of this setting.<span><span><br></span></span></div><div>3. I asked on IRC and cannot figure out why set align to i_video_width * 2.<br></div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;padding-left:1ex;border-left-color:rgb(204,204,204);border-left-width:1px;border-left-style:solid"><div><div><div class="gmail-h5"><div>
<div><br></div>
<div>On Sun, 9 Jul 2017, at 03:19, Zhao Zhili wrote:<br></div>
</div></div><blockquote type="cite"><div><div class="gmail-h5"><div dir="ltr"><div><br></div>
<div>---<br></div>
<div> modules/codec/videotoolbox.m | 3 +--<br></div>
<div> 1 file changed, 1 insertion(+), 2 deletions(-)<br></div>
<div><br></div>
<div>diff --git a/modules/codec/videotoolbox.m b/modules/codec/videotoolbox.m<br></div>
<div>index 7806bd7843..9443bbe256 100644<br></div>
<div>--- a/modules/codec/videotoolbox.m<br></div>
<div>+++ b/modules/codec/videotoolbox.m<br></div>
<div>@@ -692,8 +692,7 @@ static int StartVideoToolbox(decoder_t *p_dec)<br></div>
<div>     cfdict_set_int32(p_sys-><wbr>destinationPixelBufferAttribut<wbr>es,<br></div>
<div>                      kCVPixelBufferHeightKey, i_video_height);<br></div>
<div>     cfdict_set_int32(p_sys-><wbr>destinationPixelBufferAttribut<wbr>es,<br></div>
<div>-                     kCVPixelBufferBytesPerRowAlign<wbr>mentKey,<br></div>
<div>-                     i_video_width * 2);<br></div>
<div>+                     kCVPixelBufferBytesPerRowAlign<wbr>mentKey, 16);<br></div>
<div> <br></div>
<div>     /* setup decoder callback record */<br></div>
<div>     <wbr>VTDecompressionOutputCallbackR<wbr>ecord decoderCallbackRecord;<br></div>
<div>-- <br></div>
<div>2.11.0 (Apple Git-81)<br></div>
<div><br></div>
</div>
</div></div><div>______________________________<wbr>_________________<br></div>
<div>vlc-devel mailing list<br></div>
<div>To unsubscribe or modify your subscription options:<br></div>
<div><a href="https://mailman.videolan.org/listinfo/vlc-devel" target="_blank">https://mailman.videolan.org/<wbr>listinfo/vlc-devel</a><br></div>
</blockquote><div style="font-family:helvetica,arial,sans-serif"><br></div>
<div id="gmail-m_5882890155604285566sig60240713"><div class="gmail-m_5882890155604285566signature">--<br></div>
<div class="gmail-m_5882890155604285566signature">Jean-Baptiste Kempf -  President<br></div>
<div class="gmail-m_5882890155604285566signature">+33 672 704 734<br></div>
<div class="gmail-m_5882890155604285566signature"> <br></div>
<div class="gmail-m_5882890155604285566signature"><br></div>
</div>
<div style="font-family:helvetica,arial,sans-serif"><br></div>
</div>

<br>______________________________<wbr>_________________<br>
vlc-devel mailing list<br>
To unsubscribe or modify your subscription options:<br>
<a href="https://mailman.videolan.org/listinfo/vlc-devel" target="_blank" rel="noreferrer">https://mailman.videolan.org/<wbr>listinfo/vlc-devel</a><br></div></blockquote></div><u><br></u></div></div>