<html><head></head><body><div class="gmail_quote">Le 13 juillet 2017 14:14:55 GMT+08:00, Steve Lhomme <robux4@gmail.com> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">On Wed, Jul 12, 2017 at 5:36 PM, Rémi Denis-Courmont <remi@remlab.net> wrote:<br /><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"> On mercredi 12 juillet 2017 10:23:52 EEST Steve Lhomme wrote:<br /><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;"> vlc | branch: master | Steve Lhomme <robux4@videolabs.io> | Thu Jul 6<br /> 16:52:44 2017 +0200| [a129a5419c04f379611ef4e62021ed0f5bfab573] |<br /> committer: Jean-Baptiste Kempf<br /><br /> vlc_fourcc: add a define for "araw" (Raw PCM)<br /></blockquote><br /> Stating the painfully obvious, but araw is NOT a single codec in VLC, as can<br /> be seen in the patch context!!!<br /></blockquote><br />Not sure if you mean that like it's a bad thing. But the fact is that<br />this value is used as a shared/common value in 7 different modules.<br />Having a central define makes errors less possible and finding usage<br />easier. It will also display a more refined name in the codec list of<br />the file in the GUI.<br /><br /><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"> I think it's not an accident that Laurent did not define an alias here. Liewise<br /> aflt.<br /></blockquote><br />aflt uses a shared value in 3 different modules<br />twos uses a shared value in 6 different modules<br />sowt uses a shared value in 2 different modules<br /><br />And all of these rely on the value being set properly so that<br />vlc_fourcc_GetCodecAudio() gets the proper actual value when the<br />number of channels and bit depth are known. So I think it's better to<br />set them to solid values.<br /><br /><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"> --<br /> Rémi Denis-Courmont<br /><hr /><br /> vlc-devel mailing list<br /> To unsubscribe or modify your subscription options:<br /> <a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br /></blockquote><hr /><br />vlc-devel mailing list<br />To unsubscribe or modify your subscription options:<br /><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre></blockquote></div><br clear="all">I don't think so. They are not proper codecs, and they duplicate existing codec values. AFAIK, Tthey were left as is because they didn't make much sense.<br>
<br>
Adding defines for them is hiding the bad design and encouraging even more of it.<br>
-- <br>
Rémi Denis-Courmont<br>
Typed on an inconvenient virtual keyboard</body></html>