<html><head></head><body><div class="gmail_quote">Le 24 juillet 2017 10:50:50 GMT+03:00, Thomas Guillem <thomas@gllm.fr> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail"><br /><br />On Sun, Jul 23, 2017, at 19:26, Rémi Denis-Courmont wrote:<br /><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"> Le perjantaina 21. heinäkuuta 2017, 11.47.14 EEST Thomas Guillem a écrit<br /> :<br /><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;"> When using X11, favor glx instead of egl in order to use vdpau interop.<br /> ---<br /> modules/video_output/opengl/display.c | 25 ++++++++++++++++++++++++-<br /> 1 file changed, 24 insertions(+), 1 deletion(-)<br /> <br /> diff --git a/modules/video_output/opengl/display.c<br /> b/modules/video_output/opengl/display.c index 63376f1cd8..0e3b5e39e7 100644<br /> --- a/modules/video_output/opengl/display.c<br /> +++ b/modules/video_output/opengl/display.c<br /> @@ -103,7 +103,30 @@ static int Open (vlc_object_t *obj)<br /> goto error;<br /> }<br /> <br /> - sys->gl = vlc_gl_Create (surface, API, "$" MODULE_VARNAME);<br /> + const char *gl_name = "$" MODULE_VARNAME;<br /> +#ifndef USE_OPENGL_ES2<br /> + if (surface->type == VOUT_WINDOW_TYPE_XID)<br /> + {<br /> + switch (vd->fmt.i_chroma)<br /> + {<br /> + case VLC_CODEC_VDPAU_VIDEO_444:<br /> + case VLC_CODEC_VDPAU_VIDEO_422:<br /> + case VLC_CODEC_VDPAU_VIDEO_420:<br /> + {<br /> + /* VDPAU GL interop works only with glx for now. */<br /> + char *str = var_InheritString(surface, MODULE_VARNAME);<br /> + if (str == NULL)<br /> + gl_name = "glx";<br /> + free(str);<br /> + break;<br /> + }<br /> + default:<br /> + break;<br /> + }<br /> + }<br /></blockquote> <br /> Overriding the module preference is a terrible idea. Sooner or later,<br /> somebody <br /> will assume the variable works, but it won't. E.g. if LibVLC gained<br /> callbacks <br /> for custom GL context.<br /></blockquote><br />We respect the user choice if he override the variable. "if LibVLC<br />gained callbacks for custom GL context." This is not a problem for 3.0,<br />right ? <br /><br /><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"> <br /> -- <br /> 雷米‧德尼-库尔蒙<br /> <a href="https://www.remlab.net">https://www.remlab.net</a>/<br /> <br /><hr /><br /> vlc-devel mailing list<br /> To unsubscribe or modify your subscription options:<br /> <a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br /></blockquote><hr /><br />vlc-devel mailing list<br />To unsubscribe or modify your subscription options:<br /><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre></blockquote></div><br clear="all">I don't know if it is yet a problem. But this looks like it *will* cause run-time bugs sooner or later, and I don't really see what tge sunset/exit strategy would then be...<br>
-- <br>
Rémi Denis-Courmont<br>
Typed on an inconvenient virtual keyboard</body></html>