<!DOCTYPE html>
<html>
<head>
<title></title>
</head>
<body><div><br></div>
<div>On Mon, Jul 24, 2017, at 10:42, Shaleen Jain wrote:<br></div>
<blockquote type="cite"><div><div>Merge this as well?<br></div>
<div>Not being able to handle a GstMessage is no reason to preempt closing the decoder.<br></div>
</div>
<div><div style="white-space:pre;">Regards,
Shaleen Jain<br></div>
</div>
</blockquote><div><br></div>
<div>if default_msg_handler() returns true, this means the GstMessage is well handled and is an error.<br></div>
<div>Here, this means than gst time outed. I'm not familiar at all with gst or this module but I guess we can't do much cleanup in case of timeout and it's may be better to leak than to deadlock.<br></div>
<div><br></div>
<blockquote type="cite"><div><div>On Mon, Jul 24, 2017 at 10:16 AM, Shaleen Jain <shaleen.jain95@gmail.com> wrote:<br></div>
<blockquote type="cite"><div style="white-space:pre-wrap;"><div>---
modules/codec/gstreamer/gstdecode.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/modules/codec/gstreamer/gstdecode.c b/modules/codec/gstreamer/gstdecode.c
index 05aa500205..bbe6310291 100644
--- a/modules/codec/gstreamer/gstdecode.c
+++ b/modules/codec/gstreamer/gstdecode.c
@@ -838,7 +838,6 @@ static void CloseDecoder( vlc_object_t *p_this )
if( default_msg_handler( p_dec, p_msg ) )
{
msg_Err( p_dec, "pipeline may not close gracefully" );
- return;
}
break;
} <br></div>
<div>--<br></div>
<div>2.13.3 <br></div>
</div>
</blockquote></div>
<div><u>_______________________________________________</u><br></div>
<div>vlc-devel mailing list<br></div>
<div>To unsubscribe or modify your subscription options:<br></div>
<div><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div>
</blockquote><div><br></div>
</body>
</html>