<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jul 26, 2017 at 10:38 PM, Rémi Denis-Courmont <span dir="ltr"><<a href="mailto:remi@remlab.net" target="_blank">remi@remlab.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">Le keskiviikkona 26. heinäkuuta 2017, 19.43.34 EEST Zhao Zhili a écrit :<br>
> ---<br>
>  modules/demux/adaptive/<wbr>PlaylistManager.cpp | 3 +--<br>
>  1 file changed, 1 insertion(+), 2 deletions(-)<br>
><br>
> diff --git a/modules/demux/adaptive/<wbr>PlaylistManager.cpp<br>
> b/modules/demux/adaptive/<wbr>PlaylistManager.cpp<br>
> index f560d0f..f489a18f 100644<br>
> --- a/modules/demux/adaptive/<wbr>PlaylistManager.cpp<br>
> +++ b/modules/demux/adaptive/<wbr>PlaylistManager.cpp<br>
> @@ -664,8 +664,7 @@ void PlaylistManager::Run()<br>
>              vlc_mutex_unlock(&demux.lock);<br>
><br>
>              mutex_cleanup_push(&lock);<br>
> -            while(vlc_cond_timedwait(&<wbr>waitcond, &lock, i_deadline) == 0<br>
> -                 && i_deadline < mdate());<br>
> +            vlc_cond_timedwait(&waitcond, &lock, i_deadline);<br>
>              vlc_cleanup_pop();<br>
>          }<br>
>      }<br>
<br>
</span>The existing code is an obtuse and inefficient emulation of mwait(). It does<br>
not make much sense. But the patch is also wrong due to spurious wake-ups.<br>
<span class="HOEnZb"><font color="#888888"><br></font></span></blockquote><div><br></div><div>I think it's more similar to ControlPop() than mwait().<br></div><div><br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="HOEnZb"><font color="#888888">
--<br>
雷米‧德尼-库尔蒙<br>
<a href="https://www.remlab.net/" rel="noreferrer" target="_blank">https://www.remlab.net/</a><br>
</font></span><div class="HOEnZb"><div class="h5"><br>
______________________________<wbr>_________________<br>
vlc-devel mailing list<br>
To unsubscribe or modify your subscription options:<br>
<a href="https://mailman.videolan.org/listinfo/vlc-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/<wbr>listinfo/vlc-devel</a></div></div></blockquote></div><br></div></div>