<html><head></head><body><div class="gmail_quote">Le 27 juillet 2017 11:52:32 GMT+03:00, Steve Lhomme <robux4@gmail.com> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">On Thu, Jul 27, 2017 at 10:36 AM, Francois Cartegnie <git@videolan.org> wrote:<br /><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"> vlc | branch: master | Francois Cartegnie <fcvlcdev@free.fr> | Thu Jul 27 10:33:04 2017 +0200| [800f01edded9399f4c4721f1fcc35747d5f04678] | committer: Francois Cartegnie<br /><br /> demux: ts: add support for multiview descriptor<br /><br /><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;"> <a href="http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=800f01edded9399f4c4721f1fcc35747d5f04678">http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=800f01edded9399f4c4721f1fcc35747d5f04678</a><br /></blockquote> ---<br /><br /> modules/demux/mpeg/ts_psi.c | 25 +++++++++++++++++++++++++<br /> 1 file changed, 25 insertions(+)<br /><br /> diff --git a/modules/demux/mpeg/ts_psi.c b/modules/demux/mpeg/ts_psi.c<br /> index 4c5d0c7871..37ebab8555 100644<br /> --- a/modules/demux/mpeg/ts_psi.c<br /> +++ b/modules/demux/mpeg/ts_psi.c<br /> @@ -922,6 +922,28 @@ explicit_config_too_short:<br /> msg_Err(demux, "Opus descriptor too short");<br /> }<br /><br /> +static void PMTSetupEs0x02( ts_es_t *p_es,<br /> + const dvbpsi_pmt_es_t *p_dvbpsies )<br /> +{<br /> + /* MPEG2_stereoscopic_video_format_descriptor */<br /> + dvbpsi_descriptor_t *p_dr = PMTEsFindDescriptor( p_dvbpsies, 0x34 );<br /> + if( p_dr && p_dr->i_length > 0 && (p_dr->p_data[0] & 0x80) )<br /> + {<br /> + video_multiview_mode_t mode;<br /> + switch( p_dr->p_data[0] & 0x7F )<br /> + {<br /> + case 0x03:<br /> + mode = MULTIVIEW_STEREO_SBS; break;<br /> + case 0x04:<br /> + mode = MULTIVIEW_STEREO_TB; break;<br /> + case 0x08:<br /> + default:<br /></blockquote><br />If default means "I don't know this value" it should be set to unknown<br />(which doesn't exist yet).<br />Mohammed Huzaifa Danish has a patch to add it:<br /><br /><a href="https://code.videolan.org/GSoC2017/Shaan/vlc/commit/016a953f3e91c015fdbc2e41aeac64497edc9212">https://code.videolan.org/GSoC2017/Shaan/vlc/commit/016a953f3e91c015fdbc2e41aeac64497edc9212</a><br /><br /><br /><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"> + mode = MULTIVIEW_2D; break;<br /> + }<br /> + p_es-><a href="http://fmt.video">fmt.video</a>.multiview_mode = mode;<br /> + }<br /> +}<br /> +<br /> static void PMTSetupEs0x05PrivateData( demux_t *p_demux, ts_es_t *p_es,<br /> const dvbpsi_pmt_es_t *p_dvbpsies )<br /> {<br /> @@ -1427,6 +1449,9 @@ static void FillPESFromDvbpsiES( demux_t *p_demux,<br /><br /> switch( p_dvbpsies->i_type )<br /> {<br /> + case 0x02:<br /> + PMTSetupEs0x02( p_pes->p_es, p_dvbpsies );<br /> + break;<br /> case 0x05: /* Private data in sections */<br /> p_pes->transport = TS_TRANSPORT_SECTIONS;<br /> PMTSetupEs0x05PrivateData( p_demux, p_pes->p_es, p_dvbpsies );<br /><br /><hr /><br /> vlc-commits mailing list<br /> vlc-commits@videolan.org<br /> <a href="https://mailman.videolan.org/listinfo/vlc-commits">https://mailman.videolan.org/listinfo/vlc-commits</a><br /></blockquote><hr /><br />vlc-devel mailing list<br />To unsubscribe or modify your subscription options:<br /><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre></blockquote></div><br clear="all">Is there any content that explicitly states 2D? Otherwise the distinction with unknown does not make much sense.<br>
<br>
And the default should be 2D, anyway. Most codecs and file formats never support 3D anything (not talking about TS).<br>
-- <br>
Rémi Denis-Courmont<br>
Typed on an inconvenient virtual keyboard</body></html>