<!DOCTYPE html>
<html><head>
<title></title>
</head><body><div class="gmail_quote">Le 1 août 2017 09:35:40 GMT+03:00, Jean-Baptiste Kempf <jb@videolan.org> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div style="font-family:helvetica, arial, sans-serif;">Hello,<br /></div>
<div><br /></div>
<div>On Tue, 1 Aug 2017, at 08:32, Rémi Denis-Courmont wrote:<br /></div>
<blockquote type="cite"><div defang_data-gmailquote="yes"><div style="font-family:helvetica, arial, sans-serif;">Le 1 août 2017 00:41:50 GMT+03:00, Jean-Baptiste Kempf <jb@videolan.org> a écrit :<br /></div>
<blockquote defang_data-gmailquote="yes" style="margin-top:0pt;margin-right:0pt;margin-bottom:0pt;margin-left:0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204, 204, 204);padding-left:1ex;"><pre><div style="font-family:helvetica, arial, sans-serif;">---<br /></div>
<div style="font-family:helvetica, arial, sans-serif;"> <a href="http://configure.ac">configure.ac</a> | 6 ++++++<br /></div>
<div style="font-family:helvetica, arial, sans-serif;"> 1 file changed, 6 insertions(+)<br /></div>
<div style="font-family:helvetica, arial, sans-serif;"><br /></div>
<div style="font-family:helvetica, arial, sans-serif;">diff --git a/<a href="http://configure.ac">configure.ac</a> b/<a href="http://configure.ac">configure.ac</a><br /></div>
<div style="font-family:helvetica, arial, sans-serif;">index e303715514..fe7e273ea0 100644<br /></div>
<div style="font-family:helvetica, arial, sans-serif;">--- a/<a href="http://configure.ac">configure.ac</a><br /></div>
<div style="font-family:helvetica, arial, sans-serif;">+++ b/<a href="http://configure.ac">configure.ac</a><br /></div>
<div style="font-family:helvetica, arial, sans-serif;">@@ -1049,6 +1049,12 @@ AS_IF([test "${enable_optimizations}" != "no"], [<br /></div>
<div style="font-family:helvetica, arial, sans-serif;"> RDC_PROG_CXX_FFLAGS([no-math-errno unsafe-math-optimizations no-rounding-math no-signaling-nans cx-limited-range])<br /></div>
<div style="font-family:helvetica, arial, sans-serif;"> AC_LANG_POP<br /></div>
<div style="font-family:helvetica, arial, sans-serif;"> <br /></div>
<div style="font-family:helvetica, arial, sans-serif;">+ dnl Check for LTO<br /></div>
<div style="font-family:helvetica, arial, sans-serif;">+ RDC_PROG_CC_FFLAGS([lto])<br /></div>
<div style="font-family:helvetica, arial, sans-serif;">+ AC_LANG_PUSH(C++)<br /></div>
<div style="font-family:helvetica, arial, sans-serif;">+ RDC_PROG_CXX_FFLAGS([lto])<br /></div>
<div style="font-family:helvetica, arial, sans-serif;">+ AC_LANG_POP<br /></div>
<div style="font-family:helvetica, arial, sans-serif;">+<br /></div>
<div style="font-family:helvetica, arial, sans-serif;"> AH_BOTTOM([<br /></div>
<div style="font-family:helvetica, arial, sans-serif;"> #if defined(_MSC_VER) && !defined(__clang__)<br /></div>
<div style="font-family:helvetica, arial, sans-serif;"> # pragma fenv_access(off)<br /></div>
</pre></blockquote></div>
<div style="font-family:helvetica, arial, sans-serif;"><br /></div>
<div style="font-family:helvetica, arial, sans-serif;">ODR violations should be fixed before LTO is enabled.<br /></div>
</blockquote><div style="font-family:helvetica, arial, sans-serif;"><br /></div>
<div style="font-family:helvetica, arial, sans-serif;">Sure. I thought we destroyed most of them.<br /></div>
<div style="font-family:helvetica, arial, sans-serif;"> <br /></div>
<blockquote type="cite"><div style="font-family:helvetica, arial, sans-serif;"> And this breaks distcc and ccache, which will infuriate some devs, most probably.<br /></div>
</blockquote><div style="font-family:helvetica, arial, sans-serif;"><br /></div>
<div style="font-family:helvetica, arial, sans-serif;">Then they can override the flags, or disable optimizations.<br /></div>
<div style="font-family:helvetica, arial, sans-serif;">But seriously, VLC is now quite fast to compile on a reasonably fast machine. Contribs are not.<br /></div>
<div style="font-family:helvetica, arial, sans-serif;"><br /></div>
<div id="sig60240713"><div class="signature">--<br /></div>
<div class="signature">Jean-Baptiste Kempf - President<br /></div>
<div class="signature">+33 672 704 734<br /></div>
<div class="signature"> <br /></div>
<div class="signature"><br /></div>
</div>
<div style="font-family:helvetica, arial, sans-serif;"><br /></div>
</blockquote></div><br clear="all">There are still plenty of ODR violations across modules.<br>
<br>
Compiling Qt is very slow with LTO. Skins2 is absolutely awful. And my computer is not that bad (mid-end Haswell desktop). The loss of ccache is also quite damaging on iterative basis.<br>
-- <br>
Rémi Denis-Courmont<br>
Typed on an inconvenient virtual keyboard</body></html>