<html><head></head><body><div class="gmail_quote">Le 3 août 2017 10:36:32 GMT+03:00, Steve Lhomme <robux4@gmail.com> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">On Wed, Aug 2, 2017 at 6:06 PM, Rémi Denis-Courmont <remi@remlab.net> wrote:<br /><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"> Le keskiviikkona 2. elokuuta 2017, 17.53.11 EEST Steve Lhomme a écrit :<br /><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;"><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;"> Otherwise we just assume the changes are always accepted.<br /></blockquote><br /> That's not what the current code does.<br /></blockquote><br /> But it provides no sane way to reject the changes, other than the trivial case<br /></blockquote><br />Yes, to reject you return VLC_EGENERIC.<br /><br /><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"> of a video output that actually ignores crop and A/R entirely (in which case<br /> the distinction between reject or accept means nothing really).<br /></blockquote><br />Are you trying to add features that never existed just for the sake of it ?<br /><br /><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"> That´s why it´s wrong, leaving things half-simplified in a not very consistent<br /> shape.<br /><br /> --<br /> 雷米‧德尼-库尔蒙<br /> <a href="https://www.remlab.net">https://www.remlab.net</a>/<br /><br /><hr /><br /> vlc-devel mailing list<br /> To unsubscribe or modify your subscription options:<br /> <a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br /></blockquote><hr /><br />vlc-devel mailing list<br />To unsubscribe or modify your subscription options:<br /><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre></blockquote></div><br clear="all">No, I am not asking to add nonexistent features. I am asking to be consistent when we remove something. Those 3 patches only make sense if we officially enforce that crop&A/R changes cannot be rejected. Otherwise, committing changes before they are accepted is bad and confusing design at the very least.<br>
<br>
I am actually in favor of the simplification, as I am not aware of any problems with it.<br>
-- <br>
Rémi Denis-Courmont<br>
Typed on an inconvenient virtual keyboard</body></html>