<p dir="ltr">Thanks for the quick review.</p>
<p dir="ltr">Indeed I missed it me stupid. Updated patch following.</p>
<br><div class="gmail_quote"><div dir="ltr">On mar. 5 sept. 2017 à 09:31 Thomas Guillem <<a href="mailto:thomas@gllm.fr">thomas@gllm.fr</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hello,<br>
<br>
On Tue, Sep 5, 2017, at 01:37, Mathieu Velten wrote:<br>
> - missing break<br>
> - close is already handled in the error case of fct tc_vaegl_init<br>
> ---<br>
>  modules/video_output/opengl/converter_vaapi.c | 4 ++--<br>
>  1 file changed, 2 insertions(+), 2 deletions(-)<br>
><br>
> diff --git a/modules/video_output/opengl/converter_vaapi.c<br>
> b/modules/video_output/opengl/converter_vaapi.c<br>
> index 6ffee98fb5..9eda54ba7c 100644<br>
> --- a/modules/video_output/opengl/converter_vaapi.c<br>
> +++ b/modules/video_output/opengl/converter_vaapi.c<br>
> @@ -422,9 +422,9 @@ Open(vlc_object_t *obj)<br>
>          {<br>
>              ret = tc_vaegl_init(tc, dpy, (VANativeDisplay) (intptr_t)<br>
>              drm_fd,<br>
>                                  drm_native_destroy_cb);<br>
> +            if (ret == VLC_SUCCESS)<br>
> +                break;<br>
<br>
OK with this block.<br>
<br>
>          }<br>
> -        else<br>
> -            vlc_close(drm_fd);<br>
<br>
This vlc_close is called when dpy is NULL, so when tc_vaegl_init is not<br>
called, si it's still needed<br>
<br>
>      }<br>
>  #endif<br>
><br>
> --<br>
> 2.13.5<br>
><br>
> _______________________________________________<br>
> vlc-devel mailing list<br>
> To unsubscribe or modify your subscription options:<br>
> <a href="https://mailman.videolan.org/listinfo/vlc-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a><br>
_______________________________________________<br>
vlc-devel mailing list<br>
To unsubscribe or modify your subscription options:<br>
<a href="https://mailman.videolan.org/listinfo/vlc-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a></blockquote></div>