<br>On a side note I am not sure we should enable VAAPI VP9 decoding support for 3.0 release because of that:<br><a href="https://github.com/01org/intel-vaapi-driver/issues/262">https://github.com/01org/intel-vaapi-driver/issues/262</a><br><br>Should we provide an option ? Just disable ? If they cut a new 1.8 minor release we could probably test for the version. Support on the issue for a release appreciated ;)<div><br><div class="gmail_quote"><div dir="ltr">Le jeu. 28 déc. 2017 à 17:01, Mathieu Velten <<a href="mailto:matmaul@gmail.com">matmaul@gmail.com</a>> a écrit :<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto"><div><br><div class="gmail_extra"><div class="gmail_quote">Le 28 déc. 2017 05:16, "Steve Lhomme" <<a href="mailto:robux4@gmail.com" target="_blank">robux4@gmail.com</a>> a écrit :<br type="attribution"><blockquote class="m_-3183251185100446788quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">In any case does the ctx value get copied to the fmt later? Because we probably want to display that info in the stream Metadata.</blockquote></div></div></div><div dir="auto"><br></div></div><div dir="auto"><div dir="auto">Instead of the current patch I can copy the profile value from the ctx to fmt earlier in the generic avcodec code, only if the current fmt profile value is < 0 so we do not override a value coming from the parser. I'll try to test that tomorrow.</div></div><div dir="auto"><div dir="auto"><br></div><div dir="auto"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="m_-3183251185100446788quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="m_-3183251185100446788elided-text"><br><div class="gmail_quote"><div dir="ltr">On Thu 28 Dec 2017 at 00:36, Jean-Baptiste Kempf <<a href="mailto:jb@videolan.org" target="_blank">jb@videolan.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><u></u>
<div><div style="font-family:helvetica,arial,sans-serif">Hello Mathieu,<br></div></div><div>
<div><br></div>
<div>On Wed, 27 Dec 2017, at 12:49, Mathieu Velten wrote:<br></div>
<blockquote type="cite"><div dir="ltr"><div><div>Hi Jean-Baptiste,<br></div>
<div dir="ltr"><br></div>
<div dir="ltr">Le mer. 27 déc. 2017 à 12:04, Jean-Baptiste Kempf <<a href="mailto:jb@videolan.org" target="_blank">jb@videolan.org</a>> a écrit :<br></div>
<blockquote style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-color:rgb(204,204,204);border-left-style:solid;border-left-width:1px;padding-left:1ex"><div style="font-family:helvetica,arial,sans-serif">Hello Mathieu,<br></div>
<div style="font-family:helvetica,arial,sans-serif"> <br></div>
<div style="font-family:helvetica,arial,sans-serif"> On Tue, 26 Dec 2017, at 15:21, Mathieu Velten wrote:<br></div>
<div style="font-family:helvetica,arial,sans-serif"> > Sometimes the profile is not available in the container metadatas (WebM).<br></div>
<div style="font-family:helvetica,arial,sans-serif"> <br></div>
<div style="font-family:helvetica,arial,sans-serif"> Shouldn't the packetizer find those info?<br></div>
</blockquote><div><br></div>
<div>avparser is used to packetize VP9.<br></div>
<div>I just tried to fetch the profile after the call to av_parser_parse2 but it doesn't seem to update the avcodec context with the profile.<br></div>
</div>
</div>
</blockquote><div style="font-family:helvetica,arial,sans-serif"><br></div>
</div><div><div style="font-family:helvetica,arial,sans-serif">OK. Also, that might fix #/19196, no?<br></div></div></blockquote></div></div></blockquote></div></div></div><div dir="auto"><br></div></div><div dir="auto"><div dir="auto">Seems unrelated, software decoding is working fine on my side.</div></div><div dir="auto"><div dir="auto"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="m_-3183251185100446788quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="m_-3183251185100446788elided-text"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div style="font-family:helvetica,arial,sans-serif"></div></div><div>
<div style="font-family:helvetica,arial,sans-serif"><br></div>
<blockquote type="cite"><div dir="ltr"><div><div>I am a bit reluctant to write the whole logic to parse the profile manually there since we have the correct info directly in the decoder context at this stage.<br></div>
</div>
</div>
</blockquote><div style="font-family:helvetica,arial,sans-serif"><br></div>
</div><div><div style="font-family:helvetica,arial,sans-serif">Sure.<br></div></div><div>
<div style="font-family:helvetica,arial,sans-serif"><br></div>
<blockquote type="cite"><div dir="ltr"><div><div>However I will revert the change for HEVC since we have a full packetizer in this case, updated patch incoming.<br></div>
</div>
</div>
</blockquote><div style="font-family:helvetica,arial,sans-serif"><br></div>
</div><div><div style="font-family:helvetica,arial,sans-serif">Yes, that would be preferable, especially if we want to backport to 3.0 (I do).<br></div>
<div style="font-family:helvetica,arial,sans-serif"><br></div>
<div style="font-family:helvetica,arial,sans-serif">I'll let François and Thomas debate on that later, because I believe the discussion is not over :)<br></div>
<div style="font-family:helvetica,arial,sans-serif"><br></div>
<div style="font-family:helvetica,arial,sans-serif">Best,<br></div></div><div>
<div style="font-family:helvetica,arial,sans-serif"><br></div>
<div style="font-family:helvetica,arial,sans-serif"> <br></div>
<blockquote type="cite"><div dir="ltr"><div><blockquote style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-color:rgb(204,204,204);border-left-style:solid;border-left-width:1px;padding-left:1ex"><div style="font-family:helvetica,arial,sans-serif"><br></div>
<div style="font-family:helvetica,arial,sans-serif">> ---<br></div>
<div style="font-family:helvetica,arial,sans-serif"> > modules/codec/avcodec/vaapi.c | 11 +++++++----<br></div>
<div style="font-family:helvetica,arial,sans-serif"> > 1 file changed, 7 insertions(+), 4 deletions(-)<br></div>
<div style="font-family:helvetica,arial,sans-serif"> ><br></div>
<div style="font-family:helvetica,arial,sans-serif"> > diff --git a/modules/codec/avcodec/vaapi.c b/modules/codec/avcodec/<br></div>
<div style="font-family:helvetica,arial,sans-serif"> > vaapi.c<br></div>
<div style="font-family:helvetica,arial,sans-serif"> > index ee7fdf8..ffe537e 100644<br></div>
<div style="font-family:helvetica,arial,sans-serif"> > --- a/modules/codec/avcodec/vaapi.c<br></div>
<div style="font-family:helvetica,arial,sans-serif"> > +++ b/modules/codec/avcodec/vaapi.c<br></div>
<div style="font-family:helvetica,arial,sans-serif"> > @@ -87,9 +87,9 @@ static int GetVaProfile(AVCodecContext *ctx, const<br></div>
<div style="font-family:helvetica,arial,sans-serif"> > es_format_t *fmt,<br></div>
<div style="font-family:helvetica,arial,sans-serif"> > count = 18;<br></div>
<div style="font-family:helvetica,arial,sans-serif"> > break;<br></div>
<div style="font-family:helvetica,arial,sans-serif"> > case AV_CODEC_ID_HEVC:<br></div>
<div style="font-family:helvetica,arial,sans-serif"> > - if (fmt->i_profile == FF_PROFILE_HEVC_MAIN)<br></div>
<div style="font-family:helvetica,arial,sans-serif"> > + if (ctx->profile == FF_PROFILE_HEVC_MAIN)<br></div>
<div style="font-family:helvetica,arial,sans-serif"> > i_profile = VAProfileHEVCMain;<br></div>
<div style="font-family:helvetica,arial,sans-serif"> > - else if (fmt->i_profile == FF_PROFILE_HEVC_MAIN_10)<br></div>
<div style="font-family:helvetica,arial,sans-serif"> > + else if (ctx->profile == FF_PROFILE_HEVC_MAIN_10)<br></div>
<div style="font-family:helvetica,arial,sans-serif"> > {<br></div>
<div style="font-family:helvetica,arial,sans-serif"> > i_profile = VAProfileHEVCMain10;<br></div>
<div style="font-family:helvetica,arial,sans-serif"> > i_vlc_chroma = VLC_CODEC_VAAPI_420_10BPP;<br></div>
<div style="font-family:helvetica,arial,sans-serif"> > @@ -103,11 +103,14 @@ static int GetVaProfile(AVCodecContext *ctx, const<br></div>
<div style="font-family:helvetica,arial,sans-serif"> > es_format_t *fmt,<br></div>
<div style="font-family:helvetica,arial,sans-serif"> > count = 5;<br></div>
<div style="font-family:helvetica,arial,sans-serif"> > break;<br></div>
<div style="font-family:helvetica,arial,sans-serif"> > case AV_CODEC_ID_VP9:<br></div>
<div style="font-family:helvetica,arial,sans-serif"> > - if (fmt->i_profile == FF_PROFILE_VP9_0)<br></div>
<div style="font-family:helvetica,arial,sans-serif"> > + if (ctx->profile == FF_PROFILE_VP9_0)<br></div>
<div style="font-family:helvetica,arial,sans-serif"> > i_profile = VAProfileVP9Profile0;<br></div>
<div style="font-family:helvetica,arial,sans-serif"> > #if VA_CHECK_VERSION( 0, 39, 0 )<br></div>
<div style="font-family:helvetica,arial,sans-serif"> > - else if (fmt->i_profile == FF_PROFILE_VP9_2)<br></div>
<div style="font-family:helvetica,arial,sans-serif"> > + else if (ctx->profile == FF_PROFILE_VP9_2)<br></div>
<div style="font-family:helvetica,arial,sans-serif"> > + {<br></div>
<div style="font-family:helvetica,arial,sans-serif"> > i_profile = VAProfileVP9Profile2;<br></div>
<div style="font-family:helvetica,arial,sans-serif"> > + i_vlc_chroma = VLC_CODEC_VAAPI_420_10BPP;<br></div>
<div style="font-family:helvetica,arial,sans-serif"> > + }<br></div>
<div style="font-family:helvetica,arial,sans-serif"> > #endif<br></div>
<div style="font-family:helvetica,arial,sans-serif"> > else<br></div>
<div style="font-family:helvetica,arial,sans-serif"> > return VLC_EGENERIC;<br></div>
<div style="font-family:helvetica,arial,sans-serif"> > --<br></div>
<div style="font-family:helvetica,arial,sans-serif"> > 2.14.3<br></div>
<div style="font-family:helvetica,arial,sans-serif"> ><br></div>
<div style="font-family:helvetica,arial,sans-serif"> > _______________________________________________<br></div>
<div style="font-family:helvetica,arial,sans-serif"> > vlc-devel mailing list<br></div>
<div style="font-family:helvetica,arial,sans-serif"> > To unsubscribe or modify your subscription options:<br></div>
<div style="font-family:helvetica,arial,sans-serif"> > <a href="https://mailman.videolan.org/listinfo/vlc-devel" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div>
<div style="font-family:helvetica,arial,sans-serif"> <br></div>
<div style="font-family:helvetica,arial,sans-serif"> <br></div>
<div style="font-family:helvetica,arial,sans-serif"> --<br></div>
<div style="font-family:helvetica,arial,sans-serif"> Jean-Baptiste Kempf - President<br></div>
<div style="font-family:helvetica,arial,sans-serif"> +33 672 704 734<br></div>
</blockquote></div>
</div>
</blockquote><div style="font-family:helvetica,arial,sans-serif"><br></div>
<div id="m_-3183251185100446788m_-6513895140555451337m_-3245593150239240635sig60240713"><div class="m_-3183251185100446788m_-6513895140555451337m_-3245593150239240635signature">--<br></div>
<div class="m_-3183251185100446788m_-6513895140555451337m_-3245593150239240635signature">Jean-Baptiste Kempf - President<br></div>
<div class="m_-3183251185100446788m_-6513895140555451337m_-3245593150239240635signature">+33 672 704 734<br></div>
<div class="m_-3183251185100446788m_-6513895140555451337m_-3245593150239240635signature"> <br></div>
<div class="m_-3183251185100446788m_-6513895140555451337m_-3245593150239240635signature"><br></div>
</div>
<div style="font-family:helvetica,arial,sans-serif"><br></div>
</div>
_______________________________________________<br>
vlc-devel mailing list<br>
To unsubscribe or modify your subscription options:<br>
<a href="https://mailman.videolan.org/listinfo/vlc-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a></blockquote></div>
</div></blockquote></div><br></div></div></div></blockquote></div></div>