<!DOCTYPE html>
<html>
<head>
<title></title>
<style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}</style>
</head>
<body><div style="font-family:helvetica, arial, sans-serif;">Hello Mathieu,<br></div>
<div><br></div>
<div>On Wed, 27 Dec 2017, at 12:49, Mathieu Velten wrote:<br></div>
<blockquote type="cite"><div dir="ltr"><div defang_data-gmailquote="yes"><div>Hi Jean-Baptiste,<br></div>
<div dir="ltr"><br></div>
<div dir="ltr">Le mer. 27 déc. 2017 à 12:04, Jean-Baptiste Kempf <<a href="mailto:jb@videolan.org">jb@videolan.org</a>> a écrit :<br></div>
<blockquote defang_data-gmailquote="yes" style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-color:rgb(204, 204, 204);border-left-style:solid;border-left-width:1px;padding-left:1ex;"><div style="font-family:helvetica, arial, sans-serif;">Hello Mathieu,<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> <br></div>
<div style="font-family:helvetica, arial, sans-serif;"> On Tue, 26 Dec 2017, at 15:21, Mathieu Velten wrote:<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> > Sometimes the profile is not available in the container metadatas (WebM).<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> <br></div>
<div style="font-family:helvetica, arial, sans-serif;"> Shouldn't the packetizer find those info?<br></div>
</blockquote><div><br></div>
<div>avparser is used to packetize VP9.<br></div>
<div>I just tried to fetch the profile after the call to av_parser_parse2 but it doesn't seem to update the avcodec context with the profile.<br></div>
</div>
</div>
</blockquote><div style="font-family:helvetica, arial, sans-serif;"><br></div>
<div style="font-family:helvetica, arial, sans-serif;">OK. Also, that might fix #/19196, no?<br></div>
<div style="font-family:helvetica, arial, sans-serif;"><br></div>
<blockquote type="cite"><div dir="ltr"><div defang_data-gmailquote="yes"><div>I am a bit reluctant to write the whole logic to parse the profile manually there since we have the correct info directly in the decoder context at this stage.<br></div>
</div>
</div>
</blockquote><div style="font-family:helvetica, arial, sans-serif;"><br></div>
<div style="font-family:helvetica, arial, sans-serif;">Sure.<br></div>
<div style="font-family:helvetica, arial, sans-serif;"><br></div>
<blockquote type="cite"><div dir="ltr"><div defang_data-gmailquote="yes"><div>However I will revert the change for HEVC since we have a full packetizer in this case, updated patch incoming.<br></div>
</div>
</div>
</blockquote><div style="font-family:helvetica, arial, sans-serif;"><br></div>
<div style="font-family:helvetica, arial, sans-serif;">Yes, that would be preferable, especially if we want to backport to 3.0 (I do).<br></div>
<div style="font-family:helvetica, arial, sans-serif;"><br></div>
<div style="font-family:helvetica, arial, sans-serif;">I'll let François and Thomas debate on that later, because I believe the discussion is not over :)<br></div>
<div style="font-family:helvetica, arial, sans-serif;"><br></div>
<div style="font-family:helvetica, arial, sans-serif;">Best,<br></div>
<div style="font-family:helvetica, arial, sans-serif;"><br></div>
<div style="font-family:helvetica, arial, sans-serif;"> <br></div>
<blockquote type="cite"><div dir="ltr"><div defang_data-gmailquote="yes"><blockquote defang_data-gmailquote="yes" style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-color:rgb(204, 204, 204);border-left-style:solid;border-left-width:1px;padding-left:1ex;"><div style="font-family:helvetica, arial, sans-serif;"><br></div>
<div style="font-family:helvetica, arial, sans-serif;">> ---<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> > modules/codec/avcodec/vaapi.c | 11 +++++++----<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> > 1 file changed, 7 insertions(+), 4 deletions(-)<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> ><br></div>
<div style="font-family:helvetica, arial, sans-serif;"> > diff --git a/modules/codec/avcodec/vaapi.c b/modules/codec/avcodec/<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> > vaapi.c<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> > index ee7fdf8..ffe537e 100644<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> > --- a/modules/codec/avcodec/vaapi.c<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> > +++ b/modules/codec/avcodec/vaapi.c<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> > @@ -87,9 +87,9 @@ static int GetVaProfile(AVCodecContext *ctx, const<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> > es_format_t *fmt,<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> > count = 18;<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> > break;<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> > case AV_CODEC_ID_HEVC:<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> > - if (fmt->i_profile == FF_PROFILE_HEVC_MAIN)<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> > + if (ctx->profile == FF_PROFILE_HEVC_MAIN)<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> > i_profile = VAProfileHEVCMain;<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> > - else if (fmt->i_profile == FF_PROFILE_HEVC_MAIN_10)<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> > + else if (ctx->profile == FF_PROFILE_HEVC_MAIN_10)<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> > {<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> > i_profile = VAProfileHEVCMain10;<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> > i_vlc_chroma = VLC_CODEC_VAAPI_420_10BPP;<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> > @@ -103,11 +103,14 @@ static int GetVaProfile(AVCodecContext *ctx, const<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> > es_format_t *fmt,<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> > count = 5;<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> > break;<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> > case AV_CODEC_ID_VP9:<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> > - if (fmt->i_profile == FF_PROFILE_VP9_0)<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> > + if (ctx->profile == FF_PROFILE_VP9_0)<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> > i_profile = VAProfileVP9Profile0;<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> > #if VA_CHECK_VERSION( 0, 39, 0 )<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> > - else if (fmt->i_profile == FF_PROFILE_VP9_2)<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> > + else if (ctx->profile == FF_PROFILE_VP9_2)<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> > + {<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> > i_profile = VAProfileVP9Profile2;<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> > + i_vlc_chroma = VLC_CODEC_VAAPI_420_10BPP;<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> > + }<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> > #endif<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> > else<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> > return VLC_EGENERIC;<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> > --<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> > 2.14.3<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> ><br></div>
<div style="font-family:helvetica, arial, sans-serif;"> > _______________________________________________<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> > vlc-devel mailing list<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> > To unsubscribe or modify your subscription options:<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> > <a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div>
<div style="font-family:helvetica, arial, sans-serif;"> <br></div>
<div style="font-family:helvetica, arial, sans-serif;"> <br></div>
<div style="font-family:helvetica, arial, sans-serif;"> --<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> Jean-Baptiste Kempf - President<br></div>
<div style="font-family:helvetica, arial, sans-serif;"> +33 672 704 734<br></div>
</blockquote></div>
</div>
</blockquote><div style="font-family:helvetica, arial, sans-serif;"><br></div>
<div id="sig60240713"><div class="signature">--<br></div>
<div class="signature">Jean-Baptiste Kempf - President<br></div>
<div class="signature">+33 672 704 734<br></div>
<div class="signature"> <br></div>
<div class="signature"><br></div>
</div>
<div style="font-family:helvetica, arial, sans-serif;"><br></div>
</body>
</html>