<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Feb 7, 2018, at 8:12 PM, Martin Storsjö <<a href="mailto:martin@martin.st" class="">martin@martin.st</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">On Wed, 7 Feb 2018, Rémi Denis-Courmont wrote:</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">Le tiistaina 6. helmikuuta 2018, 23.54.55 EET Martin Storsjö a écrit :<br class=""><blockquote type="cite" class="">On Tue, 6 Feb 2018, Janne Grunau wrote:<br class="">> ---<br class="">> modules/arm_neon/amplify.S | 8 ++++--<br class="">> modules/arm_neon/asm.S | 31 +++++++++++++++++++++<br class="">> modules/arm_neon/deinterleave_chroma.S | 10 ++++---<br class="">> modules/arm_neon/i420_rgb.S | 10 ++++---<br class="">> modules/arm_neon/i420_rv16.S | 10 ++++---<br class="">> modules/arm_neon/i420_yuyv.S | 14 +++++-----<br class="">> modules/arm_neon/i422_yuyv.S | 14 +++++-----<br class="">> modules/arm_neon/nv12_rgb.S | 10 ++++---<br class="">> modules/arm_neon/nv21_rgb.S | 10 ++++---<br class="">> modules/arm_neon/simple_channel_mixer.S | 38<br class="">> +++++++++----------------- modules/arm_neon/yuyv_i422.S > | 14 +++++-----<br class="">> modules/video_filter/deinterlace/merge_arm.S | 20 ++++++--------<br class="">> modules/video_filter/deinterlace/merge_arm64.S | 10 +++----<br class="">> 13 files changed, 112 insertions(+), 87 deletions(-)<br class="">> create mode 100644 modules/arm_neon/asm.S<br class="">> > diff --git a/modules/arm_neon/amplify.S b/modules/arm_neon/amplify.S<br class="">> index 5938118378..711a3ea4f7 100644<br class="">> --- a/modules/arm_neon/amplify.S<br class="">> +++ b/modules/arm_neon/amplify.S<br class="">> @@ -18,18 +18,20 @@<br class="">> > @ Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA.<br class="">> @************************************************************************<br class="">> ****/> > +#include "asm.S"<br class="">> +<br class="">> ><span class="Apple-converted-space"> </span><span class="Apple-tab-span" style="white-space: pre;"> </span>.syntax<span class="Apple-tab-span" style="white-space: pre;"> </span>unified<br class="">><span class="Apple-converted-space"> </span><span class="Apple-tab-span" style="white-space: pre;"> </span>.arm<br class="">> > +#ifndef __APPLE__<br class="">> ><span class="Apple-converted-space"> </span><span class="Apple-tab-span" style="white-space: pre;"> </span>.fpu<span class="Apple-tab-span" style="white-space: pre;"> </span>neon<br class="">> > +#endif<br class="">> ><span class="Apple-converted-space"> </span><span class="Apple-tab-span" style="white-space: pre;"> </span>.text<br class="">Or maybe go for #ifdef __ELF__,<br class=""></blockquote><br class="">No, .fpu and .arch directives have nothing to do with the output executable format.<br class=""></blockquote><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">That's correct, but despite that, those directives are unavailable when targeting both macOS and Windows.</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">If you prefer #if !defined(__APPLE__) && !defined(_WIN32), I can live with that as well.</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""></div></blockquote><div><br class=""></div>I didn’t see this patch getting pushed into vlc yet. Is this still work in progress ?</div><div>I just want to make sure Remi and Jannes work at Fosdem is not in vain :)</div><div><br class=""></div><div>- Caro</div></body></html>