<!DOCTYPE html>
<html>
<head>
<title></title>
<style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}</style>
</head>
<body><div>Hi,<br></div>
<div><br></div>
<div>+ char *psz_glob_pat = malloc (PATH_MAX);<br></div>
<div>+ strncpy (psz_glob_pat, psz_dir, strlen (psz_dir) + 1);<br></div>
<div>+ strncat (psz_glob_pat, psz_glob_suffix, PATH_MAX - strnlen (psz_dir, PATH_MAX));<br></div>
<div><br></div>
<div>You should use asprintf here<br></div>
<div><br></div>
<div>+ if (!SetSoundfont (p_this, p_sys, "/sounds/sf2/*.sf2"))<br></div>
<div>+ if (!SetSoundfont (p_this, p_sys, "/soundfonts/*.sf2")) {}<br></div>
<div><br></div>
<div>This code is weird to read.<br></div>
<div><br></div>
<div><br></div>
<div>On Fri, Feb 23, 2018, at 10:09, Raitis V wrote:<br></div>
<blockquote type="cite"><div dir="ltr"><div>Hi,<br></div>
<div><br></div>
<div><div>The attached patch fixes the issue #19795: <a href="https://trac.videolan.org/vlc/ticket/19795">https://trac.videolan.<wbr>org/vlc/ticket/19795</a><br></div>
<div><br></div>
<div>I've compiled and tested the functionality on the 2.x branch, but it merges with should work on master too.<br></div>
<div><br></div>
<div>Out of the box soundfont detection didn't work for me on Arch Linux and not it doesn't work on NixOS, so that's why I wanted to fix this.<br></div>
<div><br></div>
<div>-- <br></div>
<div><div dir="ltr"><div>Raitis Veinbahs<br></div>
</div>
</div>
</div>
</div>
<div><u>_______________________________________________</u><br></div>
<div>vlc-devel mailing list<br></div>
<div>To unsubscribe or modify your subscription options:<br></div>
<div><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div>
<p>Email had 1 attachment:<br></p><ul><li><div><code>0001-codec-fluidsynth-look-for-sound-fonts-in-XDG_DATA_DI.patch</code><br></div>
<div> 5k (text/x-patch)<br></div>
</li></ul></blockquote><div><br></div>
</body>
</html>